Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LoadVersionForOverwriting can cause data loss #273

Closed
erikgrinaker opened this issue Jun 22, 2020 · 0 comments · Fixed by #275
Closed

LoadVersionForOverwriting can cause data loss #273

erikgrinaker opened this issue Jun 22, 2020 · 0 comments · Fixed by #275
Assignees
@erikgrinaker
Labels
T:bug Type: Bug (Confirmed)

Comments

@erikgrinaker
Copy link
Contributor

The randomized tests in #272 shows data loss with LoadVersionForOverwriting (change revertChance to e.g. 0.1). This is probably the same problem as #261, i.e. that orphans from later versions are left behind, and if the sequence of writes is different for the new versions then these orphans can incorrectly cause nodes to be deleted when they expire.
@erikgrinaker erikgrinaker added T:bug Type: Bug (Confirmed) P:High labels Jun 22, 2020
@erikgrinaker erikgrinaker changed the title LoadVersionForOverwriting causes data loss LoadVersionForOverwriting can cause data loss Jun 22, 2020
@erikgrinaker erikgrinaker mentioned this issue Jun 22, 2020
Merged
mergify bot pushed a commit that referenced this issue Jun 22, 2020
@erikgrinaker
test: add randomized tests (#272)
a41a83e 
Adds a randomized test suite. Currently disables `LoadVersionForOverwriting()` tests since it has known data corruption problems (#273). Does not cover pruning/in-memory tests, since this will be removed shortly.
@erikgrinaker erikgrinaker self-assigned this Jun 23, 2020
@erikgrinaker erikgrinaker mentioned this issue Jun 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erikgrinaker erikgrinaker

Labels
T:bug Type: Bug (Confirmed)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix LoadVersionForOverwriting data corruption cosmos/iavl
1 participant
@erikgrinaker