Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: liveness tests #1456

Merged
merged 9 commits into from
Apr 28, 2022
Merged

refactor: liveness tests #1456

merged 9 commits into from
Apr 28, 2022

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Apr 26, 2022

  • Remove old legacy docker-compose-based liveness setup and tests in favor of a more streamlined use of ignite CLI.
  • Fix CI workflows for Build & Test

@codecov
Copy link

codecov bot commented Apr 27, 2022

Codecov Report

Merging #1456 (4f057a6) into main (913c020) will increase coverage by 5.23%.
The diff coverage is 33.48%.

@@            Coverage Diff             @@
##             main    #1456      +/-   ##
==========================================
+ Coverage   10.44%   15.68%   +5.23%     
==========================================
  Files          11       10       -1     
  Lines        1082     1371     +289     
==========================================
+ Hits          113      215     +102     
- Misses        964     1145     +181     
- Partials        5       11       +6     

@alexanderbez alexanderbez mentioned this pull request Apr 27, 2022
@okwme
Copy link
Contributor

okwme commented Apr 27, 2022

ah just realized this is failing lint chcker cause you removed all the deploy-testnet.md docs. This is realted to this issue @alexanderbez : #1244
Do you have an opinion about the contents of the contrib/testnets directory Bez? Should we just nuke all of it or is any of it still used / useful in light of https://github.com/cosmos/testnets?

if: env.GIT_DIFF
- name: Test Local Network Liveness
run: |
sleep 3m
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why sleep ? and sleep so long ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ignite start a blocking process where it runs a chain, so we run the process in the background and pipe both stdout and stderr to a file. ignite takes a bit to startup (builds app, builds proto, etc...), so the 3m is just a safe "buffer" to wait for ignite to actually start the chain.


docker_containers=($(docker ps -q -f name=umeed --format='{{.Names}}'))

while [ ${CNT} -lt $ITER ]; do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is $ITER used for only counting a max looping ? if this way, can we just write while [ ${CNT} -lt $(expr ${NUMBLOCKS} + 50) ]; do then we do not need to pass the arg ITER=$1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've had this script in the SDK for years at this point. We could probably clean it up. I'm indifferent to it as it's pretty simple.

@okwme okwme merged commit c934600 into main Apr 28, 2022
@okwme okwme deleted the bez/liveness-test-refactor branch April 28, 2022 13:04
@yaruwangway
Copy link
Contributor

ah just realized this is failing lint chcker cause you removed all the deploy-testnet.md docs. This is realted to this issue @alexanderbez : #1244 Do you have an opinion about the contents of the contrib/testnets directory Bez? Should we just nuke all of it or is any of it still used / useful in light of https://github.com/cosmos/testnets?

I thought it was accidentally removed, so i add the deploy-testnet.md back to docs/hub-tutorials

tokamak-git pushed a commit that referenced this pull request May 3, 2022
* updates

* updates

* updates

* updates

* updates

* fix broken link

* add missing file

Co-authored-by: billy rennekamp <[email protected]>
Co-authored-by: Yaru Wang <[email protected]>
tokamak-git pushed a commit that referenced this pull request May 3, 2022
* updates

* updates

* updates

* updates

* updates

* fix broken link

* add missing file

Co-authored-by: billy rennekamp <[email protected]>
Co-authored-by: Yaru Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants