Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix black listed addrs bug in bank #105

Merged
merged 1 commit into from
Aug 15, 2019
Merged

Conversation

colin-axner
Copy link
Contributor

@colin-axner colin-axner commented Aug 15, 2019

fixes #104

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

@alexanderbez alexanderbez added R4R state-machine-breaking State machine breaking changes (impacts consensus). labels Aug 15, 2019
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@codecov-io
Copy link

Codecov Report

Merging #105 into master will increase coverage by 0.43%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #105      +/-   ##
==========================================
+ Coverage   67.31%   67.74%   +0.43%     
==========================================
  Files           3        3              
  Lines         462      462              
==========================================
+ Hits          311      313       +2     
+ Misses        120      118       -2     
  Partials       31       31

@alexanderbez alexanderbez merged commit 5cad071 into master Aug 15, 2019
@alexanderbez alexanderbez deleted the colin/104-blacklistedaddrs branch August 15, 2019 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state-machine-breaking State machine breaking changes (impacts consensus).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BankKeeper is not passing in correct black listed addresses
3 participants