-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update IBC host keys + cleanup #7873
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7873 +/- ##
==========================================
- Coverage 54.19% 54.19% -0.01%
==========================================
Files 610 610
Lines 38844 38846 +2
==========================================
Hits 21051 21051
- Misses 15637 15639 +2
Partials 2156 2156 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK, though I agree with @AdityaSripal's comment
Description
I changed the redundant
packets
acknowledgements
andreceipts
to usesequences
to follow the nomenclature ofports/{}/channels/{}
closes: #7713 #7710
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes