Use gRPC in GetCmdQueryValidators #7626
Conversation
Codecov Report
@@ Coverage Diff @@
## robert/validator-pubkey #7626 +/- ##
===========================================================
- Coverage 59.82% 57.23% -2.60%
===========================================================
Files 317 453 +136
Lines 17992 27723 +9731
===========================================================
+ Hits 10763 15866 +5103
- Misses 6081 10331 +4250
- Partials 1148 1526 +378 |
| return res, height, err | ||
| } | ||
|
|
||
| ctx.LegacyAmino.MustUnmarshalBinaryBare(resRaw, &res) |
There was a problem hiding this comment.
I fmt.Printlned the res here, it's a []KVPair of []bytes->[]bytes, and I'm assuming those bytes are proto-encoded.
This means that the client.Context would need to hold a reference to the BinaryMarshaler too, which seems like a code smell.
Instead, I deleted this function (only used in 1 place), and used gRPC queries in GetCmdQueryValidators.
There was a problem hiding this comment.
So, I assume we are.ok to delete this public function?
| @@ -22,7 +22,7 @@ import ( | |||
|
|
|||
| func TestMsgService(t *testing.T) { | |||
| priv, _, _ := testdata.KeyTestPubAddr() | |||
| encCfg := simapp.MakeEncodingConfigTests() | |||
| encCfg := simapp.MakeEncodingConfig() | |||
There was a problem hiding this comment.
Why do you change this?
There was a problem hiding this comment.
| return res, height, err | ||
| } | ||
|
|
||
| ctx.LegacyAmino.MustUnmarshalBinaryBare(resRaw, &res) |
There was a problem hiding this comment.
So, I assume we are.ok to delete this public function?
amaury1093
requested review from
aaronc,
alessio and
alexanderbez
as code owners
Description
to be merged into #7597
GetCmdQueryValidatorsto use gRPC and outputs protoJSON instead of aminoJSON (this fixes the test)Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes