Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types: tests -> test suites migration #7400

Merged
merged 9 commits into from
Sep 28, 2020
Merged

types: tests -> test suites migration #7400

merged 9 commits into from
Sep 28, 2020

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Sep 27, 2020 •
edited
Loading

Ref #7362

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Sep 27, 2020 •
edited
Loading

Codecov Report

Merging #7400 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #7400   +/-   ##
=======================================
  Coverage   55.35%   55.35%           
=======================================
  Files         587      587           
  Lines       36469    36469           
=======================================
  Hits        20189    20189           
  Misses      14192    14192           
  Partials     2088     2088

@alessio alessio marked this pull request as ready for review September 28, 2020 07:22
@alessio alessio changed the title add more test suites types: tests -> test suites migration Sep 28, 2020
tac0turtle
tac0turtle reviewed Sep 28, 2020
View reviewed changes
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

tac0turtle
tac0turtle approved these changes Sep 28, 2020
View reviewed changes
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops

@alessio alessio merged commit 8601dcd into master Sep 28, 2020
@alessio alessio deleted the alessio/types-test-suites branch September 28, 2020 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgimeno jgimeno jgimeno approved these changes

@tac0turtle tac0turtle tac0turtle approved these changes

@sahith-narahari sahith-narahari Awaiting requested review from sahith-narahari

@aaronc aaronc Awaiting requested review from aaronc

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alessio @jgimeno @tac0turtle