tendermint: update to rc3 #6892

tac0turtle · 2020-07-30T09:43:00Z

Description

Base PR for all related tendermint changes needed for rc3

ref #6365

colin-axner

import changes thus far lgtm

go.mod

x/staking/keeper/querier_test.go

colin-axner

ACK - for import naming changes

go.mod

alexanderbez

❤️ 💜 🖤

I would say we can even move this out of draft mode.

zmanian · 2020-07-31T22:45:35Z

https://github.com/cosmos/cosmos-sdk/blob/tm_update_1/codec/amino.go#L34-L36

relies on an Amino Register function that no longer exists on the Tendermint side.

Do we already have strategy for replacing this or are we looking for suggestion?

tac0turtle · 2020-08-01T09:40:38Z

Do we already have strategy for replacing this or are we looking for suggestion?

I am a bit lost on why the sdk registered Evidence in the codec in the first place? Could you explain the need for sdk to register this?

Tendermint provides abci.Evidence, which is not the concrete type(s) of evidence. For the Rest Server it is again using a custom type and not the tendermint native types.

tac0turtle · 2020-08-07T08:55:42Z

it doesnt fully complete the issue, but parts of it

Co-authored-by: Aleksandr Bezobchuk <[email protected]> Co-authored-by: Cory Levinson <[email protected]>

tac0turtle · 2020-08-14T08:17:15Z

@alexanderbez @fedekunze @colin-axner want to do a double take?

Makefile

fedekunze · 2020-08-14T14:57:45Z

x/ibc/07-tendermint/types/client_state_test.go

@@ -62,21 +62,11 @@ func (suite *TendermintTestSuite) TestValidate() {
 		},
 		{
 			name:        "invalid height",
-			clientState: ibctmtypes.NewClientState(chainID, types.DefaultTrustLevel, trustingPeriod, ubdPeriod, maxClockDrift, 0, commitmenttypes.GetSDKSpecs()),


not sure why these test cases got removed. The name doesn't match the error

reverted but got failing tests now

x/ibc/07-tendermint/types/header.go

x/ibc/07-tendermint/types/test_utils.go

Co-authored-by: Federico Kunze <[email protected]>

fedekunze

Did a final pass over all the baseapp, types, simapp, staking, capability, evidence and ibc(-transfer) pkgs. All changes LGTM! 🚀

* modify light imports * change abci.header to tmproto.header * use rc * rc * fix import * Merge PR cosmos#6893: fix key imports * fix rc2 * tendermint: update 3 (cosmos#6899) * tendermint: update 4 (cosmos#6919) Co-authored-by: Alexander Bezobchuk <[email protected]> * tendermint: update 5 (cosmos#6923) Co-authored-by: Federico Kunze <[email protected]> * bump to latest master * tendermint: update (cosmos#6972) Co-authored-by: Aleksandr Bezobchuk <[email protected]> Co-authored-by: Cory Levinson <[email protected]> * Update x/ibc/07-tendermint/types/test_utils.go Co-authored-by: Federico Kunze <[email protected]> * address comment * go mod * bring back things * fix test * update tm proto files Co-authored-by: Alexander Bezobchuk <[email protected]> Co-authored-by: Federico Kunze <[email protected]> Co-authored-by: Aleksandr Bezobchuk <[email protected]> Co-authored-by: Cory Levinson <[email protected]> Co-authored-by: Federico Kunze <[email protected]>

tac0turtle added 3 commits July 30, 2020 11:41

modify light imports

554a0cf

change abci.header to tmproto.header

d3534f0

Merge branch 'master' into tm_update_1

49aea06

colin-axner reviewed Jul 30, 2020

View reviewed changes

go.mod Outdated Show resolved Hide resolved

x/staking/keeper/querier_test.go Outdated Show resolved Hide resolved

tac0turtle added 4 commits July 30, 2020 13:42

use rc

f781527

rc

11d3f78

fix import

f98e70a

Merge branch 'master' into tm_update_1

03052b4

colin-axner approved these changes Jul 30, 2020

View reviewed changes

alexanderbez reviewed Jul 30, 2020

View reviewed changes

go.mod Outdated Show resolved Hide resolved

alexanderbez approved these changes Jul 30, 2020

View reviewed changes

Merge branch 'master' into tm_update_1

dc9b87a

tac0turtle marked this pull request as ready for review July 30, 2020 14:38

tac0turtle requested review from aaronc, alessio, clevinson, fedekunze and jgimeno as code owners July 30, 2020 14:38

tac0turtle added 2 commits July 30, 2020 10:42

Merge PR #6893: fix key imports

331ba70

fix rc2

96d8a51

tac0turtle self-assigned this Jul 30, 2020

tac0turtle added the C: comet label Jul 30, 2020

fedekunze approved these changes Jul 30, 2020

View reviewed changes

tac0turtle and others added 3 commits July 30, 2020 16:54

Merge branch 'master' into tm_update_1

660ca11

Merge branch 'master' into tm_update_1

e1d04b7

tendermint: update 3 (#6899)

0dcc665

tac0turtle changed the title ~~tendermint: update 1~~ tendermint: update to rc2 Jul 30, 2020

tac0turtle mentioned this pull request Jul 30, 2020

tendermint: Update to master #6471

Closed

webmaster128 mentioned this pull request Aug 7, 2020

Add Tendermint 0.34 client support cosmos/cosmjs#344

Closed

tac0turtle added 2 commits August 11, 2020 13:07

Merge branch 'master' into tm_update_1

0193208

Merge branch 'master' into tm_update_1

b0884e9

aaronc added this to the v0.40 [Stargate] milestone Aug 11, 2020

tac0turtle and others added 5 commits August 12, 2020 16:13

Merge branch 'master' into tm_update_1

280a4af

Merge branch 'master' into tm_update_1

144234b

Merge branch 'master' into tm_update_1

48ac48f

tendermint: update (#6972)

82f0abc

Co-authored-by: Aleksandr Bezobchuk <[email protected]> Co-authored-by: Cory Levinson <[email protected]>

Merge branch 'master' into tm_update_1

3fb12d0

tac0turtle changed the title ~~tendermint: update to rc2~~ tendermint: update to rc3 Aug 14, 2020

clevinson reviewed Aug 14, 2020

View reviewed changes

Makefile Outdated Show resolved Hide resolved

aaronc requested review from amaury1093, anilcse, atheeshp and blushi August 14, 2020 14:21

fedekunze reviewed Aug 14, 2020

View reviewed changes

tac0turtle and others added 7 commits August 14, 2020 17:21

Update x/ibc/07-tendermint/types/test_utils.go

b5e7705

Co-authored-by: Federico Kunze <[email protected]>

address comment

22d47e2

Merge branch 'master' into tm_update_1

af478fb

go mod

12a7ac5

bring back things

dc4782c

fix test

09feb5d

update tm proto files

9cdb890

fedekunze reviewed Aug 14, 2020

View reviewed changes

fedekunze merged commit 8de96d1 into master Aug 14, 2020

fedekunze deleted the tm_update_1 branch August 14, 2020 17:58

odeke-em mentioned this pull request Dec 6, 2020

x/ibc/core/23-commitment/types: fix MerkleProof.Empty comparisons #8092

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

tendermint: update to rc3 #6892

tendermint: update to rc3 #6892

tac0turtle commented Jul 30, 2020 •

edited by clevinson

Loading

colin-axner left a comment

colin-axner left a comment

alexanderbez left a comment •

edited

Loading

zmanian commented Jul 31, 2020 •

edited

Loading

tac0turtle commented Aug 1, 2020

tac0turtle commented Aug 7, 2020

tac0turtle commented Aug 14, 2020

fedekunze Aug 14, 2020

tac0turtle Aug 14, 2020

fedekunze left a comment •

edited

Loading

tendermint: update to rc3 #6892

tendermint: update to rc3 #6892

Conversation

tac0turtle commented Jul 30, 2020 • edited by clevinson Loading

Description

colin-axner left a comment

Choose a reason for hiding this comment

colin-axner left a comment

Choose a reason for hiding this comment

alexanderbez left a comment • edited Loading

Choose a reason for hiding this comment

zmanian commented Jul 31, 2020 • edited Loading

tac0turtle commented Aug 1, 2020

tac0turtle commented Aug 7, 2020

tac0turtle commented Aug 14, 2020

fedekunze Aug 14, 2020

Choose a reason for hiding this comment

tac0turtle Aug 14, 2020

Choose a reason for hiding this comment

fedekunze left a comment • edited Loading

Choose a reason for hiding this comment

tac0turtle commented Jul 30, 2020 •

edited by clevinson

Loading

alexanderbez left a comment •

edited

Loading

zmanian commented Jul 31, 2020 •

edited

Loading

fedekunze left a comment •

edited

Loading