-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove viper global single from x/staking #6631
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6631 +/- ##
==========================================
- Coverage 57.58% 57.50% -0.09%
==========================================
Files 500 500
Lines 29999 30024 +25
==========================================
- Hits 17275 17264 -11
- Misses 11479 11515 +36
Partials 1245 1245 |
This pull request introduces 1 alert when merging a7d4a58 into a459b78 - view on LGTM.com new alerts:
|
…mos-sdk into jonathan/viper-staking-module
jgimeno
requested review from
aaronc,
alessio,
alexanderbez,
clevinson and
fedekunze
as code owners
July 8, 2020 19:47
alexanderbez
added
C:CLI
Type: Code Hygiene
General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
C:x/staking
labels
Jul 8, 2020
alexanderbez
approved these changes
Jul 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
alessio
changed the title
Remove viper in Staking module.
Remove viper global single from x/staking
Nov 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C:CLI
C:x/staking
Type: Code Hygiene
General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes