Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spring cleanup #5991

Merged
merged 3 commits into from
Apr 14, 2020
Merged

spring cleanup #5991

merged 3 commits into from
Apr 14, 2020

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Apr 14, 2020

Run make format and fix lint warnings.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alessio alessio added R4R A:automerge Automatically merge PR once all prerequisites pass. labels Apr 14, 2020
@alessio alessio requested review from jgimeno and tac0turtle April 14, 2020 18:21
@codecov
Copy link

codecov bot commented Apr 14, 2020

Codecov Report

Merging #5991 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5991      +/-   ##
==========================================
+ Coverage   58.23%   58.25%   +0.01%     
==========================================
  Files         396      396              
  Lines       23621    23603      -18     
==========================================
- Hits        13756    13749       -7     
+ Misses       8905     8893      -12     
- Partials      960      961       +1     

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@mergify mergify bot merged commit aeee097 into master Apr 14, 2020
@mergify mergify bot deleted the alessio/format-and-linter branch April 14, 2020 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants