Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Restart application issue #5579

Merged
merged 26 commits into from
Feb 6, 2020
Merged
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
a540b0e
fix commitID along with adding new SnapshotEvery parameter to cleanup…
AdityaSripal Jan 28, 2020
253ad5c
fix commitID along with adding new SnapshotEvery parameter to cleanup…
AdityaSripal Jan 28, 2020
f1e5ba9
remove file from unrelated debugging worl
AdityaSripal Jan 28, 2020
923f1e5
fix cleanup bug
AdityaSripal Jan 28, 2020
a35591b
add iavl tests
AdityaSripal Jan 28, 2020
0ae90d8
add rootmulti tests
AdityaSripal Jan 29, 2020
d612e56
add baseapp tests along with Version method on CommitStore
AdityaSripal Jan 29, 2020
63bd983
cleanup from review
AdityaSripal Jan 29, 2020
9e4b434
Merge branch 'master' into aditya/pruning-fixes
alexanderbez Jan 29, 2020
fbd1a52
Update store/types/pruning.go
AdityaSripal Jan 29, 2020
42fc8ef
initial fixes
AdityaSripal Jan 31, 2020
aa81b5d
fix query bugs by replacing lastCommitID with lastCommitInfo
AdityaSripal Jan 31, 2020
67d5087
Merge branch 'aditya/pruning-fixes' of https://github.com/cosmos/cosm…
AdityaSripal Jan 31, 2020
c9c0fd1
start addressing review comments
AdityaSripal Jan 31, 2020
f041162
further cleanup
AdityaSripal Jan 31, 2020
d52da2c
enforce keepRecent is either 0 or 1
AdityaSripal Feb 5, 2020
f52fa5e
Merge branch 'master' into aditya/pruning-fixes
alexanderbez Feb 5, 2020
5fab6cd
address comments and remove keepRecent from user-facing pruning options
AdityaSripal Feb 6, 2020
c811093
Merge branch 'aditya/pruning-fixes' of https://github.com/cosmos/cosm…
AdityaSripal Feb 6, 2020
4fa7fe7
address last comments on review
AdityaSripal Feb 6, 2020
e8676ab
Linting and cleanup
alexanderbez Feb 6, 2020
d8186a6
More linting
alexanderbez Feb 6, 2020
b210d0e
More linting
alexanderbez Feb 6, 2020
5b00d1a
Edit changelog
alexanderbez Feb 6, 2020
5102a90
Merge branch 'master' into aditya/pruning-fixes
alexanderbez Feb 6, 2020
6e67a1b
Merge branch 'master' into aditya/pruning-fixes
alexanderbez Feb 6, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update store/types/pruning.go
Co-Authored-By: Alexander Bezobchuk <[email protected]>
  • Loading branch information
AdityaSripal and alexanderbez authored Jan 29, 2020
commit fbd1a52fff85d80eae85d27be14c4662816f7b8f
2 changes: 1 addition & 1 deletion store/types/pruning.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ func NewPruningOptions(keepRecent, keepEvery, snapshotEvery int64) PruningOption
// SnapshotEvery is a multiple of KeepEvery
func (po PruningOptions) IsValid() bool {
// If we're flushing periodically, we must make in-memory cache less than
// that period to avoid inefficiency and undefined behavior
// that period to avoid inefficiency and undefined behavior.
if po.keepEvery != 0 && po.keepRecent > po.keepEvery {
return false
}
Expand Down