IBC-SDK Integration #5057
Merged
IBC-SDK Integration #5057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golangcibot
reviewed
Sep 17, 2019
Codecov Report
@@ Coverage Diff @@
## joon/ics-04-implementation #5057 +/- ##
==============================================================
+ Coverage 55.98% 56.09% +0.11%
==============================================================
Files 307 308 +1
Lines 18576 18585 +9
==============================================================
+ Hits 10399 10425 +26
+ Misses 7456 7433 -23
- Partials 721 727 +6 |
golangcibot
reviewed
Sep 19, 2019
golangcibot
reviewed
Sep 20, 2019
| } | ||
| _, pstate, err := obj1.StateCLI(ctx1) | ||
|
|
||
| err = utils.GenerateOrBroadcastMsgs(ctx2, txBldr, []sdk.Msg{msgupdate}) |
There was a problem hiding this comment.
ineffectual assignment to err (from ineffassign)
| } | ||
| _, pstate, err = obj2.State(ctx2) | ||
|
|
||
| err = utils.GenerateOrBroadcastMsgs(ctx1, txBldr, []sdk.Msg{msgupdate}) |
There was a problem hiding this comment.
ineffectual assignment to err (from ineffassign)
| Signer: ctx2.GetFromAddress(), | ||
| } | ||
|
|
||
| err = utils.GenerateOrBroadcastMsgs(ctx2, txBldr, []sdk.Msg{msgupdate}) |
There was a problem hiding this comment.
ineffectual assignment to err (from ineffassign)
| } | ||
|
|
||
| err = utils.GenerateOrBroadcastMsgs(ctx1, txBldr, []sdk.Msg{msginit}) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| timeout := nextTimeout | ||
| height, err = lastheight(ctx1) | ||
| // Another block has to be passed after msginit is commited |
There was a problem hiding this comment.
commited is a misspelling of committed (from misspell)
| } | ||
|
|
||
| err = utils.GenerateOrBroadcastMsgs(ctx2, txBldr, []sdk.Msg{msgtry}) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| timeout = nextTimeout | ||
| height, err = lastheight(ctx2) | ||
| // Another block has to be passed after msginit is commited |
There was a problem hiding this comment.
commited is a misspelling of committed (from misspell)
| } | ||
|
|
||
| err = utils.GenerateOrBroadcastMsgs(ctx1, txBldr, []sdk.Msg{msgack}) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| timeout = nextTimeout | ||
| _, pstate, err = obj1.State(ctx1) | ||
| // Another block has to be passed after msginit is commited |
There was a problem hiding this comment.
commited is a misspelling of committed (from misspell)
golangcibot
reviewed
Sep 25, 2019
|
There was a naming cleanup in this PR which is not reflected in the previous PRs.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Moved to #5124
(@fedekunze: Sorry I deleted the changes by mistake when I pulled on the downstream PR )
This will be the final version of sdk integration pr, I hope.
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added a relevant changelog entry to the
Unreleasedsection inCHANGELOG.mdRe-reviewed
Files changedin the github PR explorerFor Admin Use: