Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation on how to sign Cosmos transactions #3968

Merged
merged 3 commits into from
Mar 25, 2019

Conversation

zmanian
Copy link
Member

@zmanian zmanian commented Mar 24, 2019

Update documentation to include details on how to sign Cosmos transactions for service providers.


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@zmanian zmanian added the T:Docs Changes and features related to documentation. label Mar 24, 2019
@codecov
Copy link

codecov bot commented Mar 24, 2019

Codecov Report

Merging #3968 into develop will increase coverage by 1.03%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #3968      +/-   ##
===========================================
+ Coverage    60.45%   61.48%   +1.03%     
===========================================
  Files          196      186      -10     
  Lines        14485    13978     -507     
===========================================
- Hits          8757     8595     -162     
+ Misses        5147     4836     -311     
+ Partials       581      547      -34

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notes, suggestions, a few typos.

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Depending on what prompted this documentation, other things that could be worth mentioning are:

  • How to compose multi-Msg transactions (likely more efficient in many cases)
  • Memo limitations

@cwgoes cwgoes merged commit 2788c22 into develop Mar 25, 2019
@cwgoes cwgoes deleted the zaki/signing_to_provider_doc branch March 25, 2019 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T:Docs Changes and features related to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants