Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: fixes for biased simulation RandomAmount #3737

Conversation

rigelrozanski
Copy link
Contributor

ref #3735

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Feb 26, 2019

Codecov Report

Merging #3737 into cwgoes/alternative-negative-coins-fix will decrease coverage by 0.08%.
The diff coverage is 11.11%.

@@                            Coverage Diff                            @@
##           cwgoes/alternative-negative-coins-fix    #3737      +/-   ##
=========================================================================
- Coverage                                  61.23%   61.15%   -0.09%     
=========================================================================
  Files                                        190      190              
  Lines                                      14042    14050       +8     
=========================================================================
- Hits                                        8599     8592       -7     
- Misses                                      4905     4919      +14     
- Partials                                     538      539       +1

@rigelrozanski rigelrozanski changed the base branch from develop to cwgoes/alternative-negative-coins-fix February 26, 2019 00:03
@jaekwon
Copy link
Contributor

jaekwon commented Feb 26, 2019

I'm not much in favor of supporting unbiased random generators... what's the point of not biasing?

@rigelrozanski
Copy link
Contributor Author

closing in favour of #3744

@rigelrozanski rigelrozanski deleted the rigel/sim-edge-case-fix branch February 27, 2019 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants