Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge release back to develop #2590

Merged
merged 16 commits into from
Oct 25, 2018
Merged

Merge release back to develop #2590

merged 16 commits into from
Oct 25, 2018

Conversation

cwgoes
Copy link
Contributor

@cwgoes cwgoes commented Oct 24, 2018 •
edited
Loading

Merge v0.25.0 release branch back to develop.

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

zramsay and others added 12 commits August 29, 2018 15:37
@cwgoes cwgoes mentioned this pull request Oct 24, 2018
Closed
Aleksandr Bezobchuk and others added 3 commits October 24, 2018 16:34
@codecov
Copy link

codecov bot commented Oct 25, 2018

Codecov Report

Merging #2590 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #2590   +/-   ##
========================================
  Coverage    58.87%   58.87%           
========================================
  Files          152      152           
  Lines         9411     9411           
========================================
  Hits          5541     5541           
  Misses        3501     3501           
  Partials       369      369

@cwgoes
Copy link
Contributor Author

cwgoes commented Oct 25, 2018

Let's merge this so we can further debug #2573 (comment).

alexanderbez
alexanderbez approved these changes Oct 25, 2018
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testedACK.

@cwgoes cwgoes merged commit 3ccc06a into develop Oct 25, 2018
@cwgoes cwgoes deleted the release/v0.25.0 branch October 25, 2018 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderbez alexanderbez alexanderbez approved these changes

@ebuchman ebuchman Awaiting requested review from ebuchman

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

@zramsay zramsay Awaiting requested review from zramsay

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@cwgoes @alexanderbez @zramsay @greg-szabo @faboweb @ebuchman @jbibla @alessio