Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: correct explanation on how to set custom signer via depinject (backport #23654) #23663

Merged
merged 2 commits into from
Feb 12, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 12, 2025

Description

documentation was unclear, causing confusion for users. This should fix it.
cc @johnletey


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:

  • confirmed ! in the type prefix if API or client breaking change

  • targeted the correct branch (see PR Targeting)

  • provided a link to the relevant issue or specification

  • reviewed "Files changed" and left comments if necessary

  • included the necessary unit and integration tests

  • added a changelog entry to CHANGELOG.md

  • updated the relevant documentation or specification, including comments for documenting Go code

  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

  • New Features

    • Introduced enhanced transaction signing with support for custom message processing, improving how messages are structured and handled.
  • Refactor

    • Streamlined the initialization and integration process for transaction signing to ensure a more robust and consistent configuration experience.

This is an automatic backport of pull request #23654 done by [Mergify](https://mergify.com).

…23654)

Co-authored-by: John Letey <[email protected]>
(cherry picked from commit e3718e0)

# Conflicts:
#	docs/build/building-modules/02-messages-and-queries.md
Copy link
Contributor Author

mergify bot commented Feb 12, 2025

Cherry-pick of e3718e0 has failed:

On branch mergify/bp/release/v0.50.x/pr-23654
Your branch is up to date with 'origin/release/v0.50.x'.

You are currently cherry-picking commit e3718e06c.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   docs/build/building-modules/02-messages-and-queries.md

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot added the conflicts label Feb 12, 2025
@mergify mergify bot requested a review from a team as a code owner February 12, 2025 00:13
@aljo242 aljo242 merged commit effb71f into release/v0.50.x Feb 12, 2025
42 of 44 checks passed
@aljo242 aljo242 deleted the mergify/bp/release/v0.50.x/pr-23654 branch February 12, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants