Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove unused orm module (backport #23633) #23637

Merged
merged 1 commit into from
Feb 12, 2025
Merged

chore: remove unused orm module (backport #23633) #23637

merged 1 commit into from
Feb 12, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 7, 2025

Description

Closes: #23635

On the releases/v0.50.x branch there is a failing test for the orm module. It looks like this module has not been in active development for some time, and is isolated into it's own module that was last released 2 years ago (https://github.com/cosmos/cosmos-sdk/tree/orm/v1.0.0-beta.3). The failing test was fixed on the main branch, but was not backported to the releases/v0.50.x.

Since the module is not in active development, and I am unaware of plans to continue development of the module, I recommend removing the module from the main branch, and backporting it to releases/v0.50.x.

Deleting orm from the Cosmos SDK repo is safe, even on the v0.50.x branch because it is isolated into it's own module, and the cosmos-sdk doesn't depend on it. So as far as cosmos-sdk releases are concerned the deletion of the module has no effect, and thus is non-breaking.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:

  • confirmed ! in the type prefix if API or client breaking change

  • targeted the correct branch (see PR Targeting)

  • provided a link to the relevant issue or specification

  • reviewed "Files changed" and left comments if necessary

  • included the necessary unit and integration tests

  • added a changelog entry to CHANGELOG.md

  • updated the relevant documentation or specification, including comments for documenting Go code

  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage
This is an automatic backport of pull request #23633 done by [Mergify](https://mergify.com).

@zrbecker @mergify
chore: remove unused orm module (#23633)
b094d98 
(cherry picked from commit d7f101e)

# Conflicts:
#	orm/CHANGELOG.md
#	orm/README.md
#	orm/encoding/encodeutil/util.go
#	orm/encoding/ormfield/bool.go
#	orm/encoding/ormfield/codec_test.go
#	orm/encoding/ormfield/duration.go
#	orm/encoding/ormfield/duration_test.go
#	orm/encoding/ormfield/enum.go
#	orm/encoding/ormfield/int32.go
#	orm/encoding/ormfield/int64.go
#	orm/encoding/ormfield/string.go
#	orm/encoding/ormfield/timestamp.go
#	orm/encoding/ormfield/timestamp_test.go
#	orm/encoding/ormfield/uint32.go
#	orm/encoding/ormfield/uint64.go
#	orm/encoding/ormkv/index_key.go
#	orm/encoding/ormkv/key_codec.go
#	orm/encoding/ormkv/primary_key.go
#	orm/encoding/ormkv/unique_key.go
#	orm/encoding/ormkv/unique_key_test.go
#	orm/go.mod
#	orm/go.sum
#	orm/internal/codegen/file.go
#	orm/internal/codegen/index.go
#	orm/internal/codegen/query.go
#	orm/internal/listinternal/options.go
#	orm/internal/testkv/compare.go
#	orm/internal/testkv/debug.go
#	orm/internal/testkv/leveldb.go
#	orm/internal/testkv/mem.go
#	orm/model/ormdb/genesis.go
#	orm/model/ormdb/module.go
#	orm/model/ormdb/module_test.go
#	orm/model/ormtable/auto_increment_test.go
#	orm/model/ormtable/backend.go
#	orm/model/ormtable/batch.go
#	orm/model/ormtable/bench_test.go
#	orm/model/ormtable/hooks.go
#	orm/model/ormtable/iterator.go
#	orm/model/ormtable/table_test.go
#	orm/orm.go
#	orm/sonar-project.properties
#	orm/testing/ormmocks/hooks.go
#	orm/testing/ormmocks/match.go
#	orm/types/kv/store.go
#	orm/types/ormerrors/errors.go
@mergify mergify bot requested a review from a team as a code owner February 7, 2025 18:17
@mergify Mergify
Copy link
Contributor Author

mergify bot commented Feb 7, 2025

Cherry-pick of d7f101e has failed:

On branch mergify/bp/release/v0.50.x/pr-23633
Your branch is up to date with 'origin/release/v0.50.x'.

You are currently cherry-picking commit d7f101e6a.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	deleted:    orm/Makefile
	deleted:    orm/cmd/protoc-gen-go-cosmos-orm-proto/main.go
	deleted:    orm/cmd/protoc-gen-go-cosmos-orm/main.go
	deleted:    orm/encoding/docs.go
	deleted:    orm/encoding/ormfield/bytes.go
	deleted:    orm/encoding/ormfield/codec.go
	deleted:    orm/encoding/ormkv/codec.go
	deleted:    orm/encoding/ormkv/entry.go
	deleted:    orm/encoding/ormkv/entry_test.go
	deleted:    orm/encoding/ormkv/index_key_test.go
	deleted:    orm/encoding/ormkv/key_codec_test.go
	deleted:    orm/encoding/ormkv/primary_key_test.go
	deleted:    orm/encoding/ormkv/seq.go
	deleted:    orm/encoding/ormkv/seq_test.go
	deleted:    orm/features/table/saving.feature
	deleted:    orm/internal/buf.gen.yaml
	deleted:    orm/internal/buf.proto.gen.yaml
	deleted:    orm/internal/buf.yaml
	deleted:    orm/internal/codegen/codegen.go
	deleted:    orm/internal/codegen/singleton.go
	deleted:    orm/internal/codegen/table.go
	deleted:    orm/internal/fieldnames/fieldnames.go
	deleted:    orm/internal/fieldnames/fieldnames_test.go
	deleted:    orm/internal/stablejson/encode.go
	deleted:    orm/internal/stablejson/encode_test.go
	deleted:    orm/internal/testpb/bank.cosmos_orm.go
	deleted:    orm/internal/testpb/bank.pb.go
	deleted:    orm/internal/testpb/bank.proto
	deleted:    orm/internal/testpb/bank_query.pb.go
	deleted:    orm/internal/testpb/bank_query.proto
	deleted:    orm/internal/testpb/bank_query_grpc.pb.go
	deleted:    orm/internal/testpb/test_schema.cosmos_orm.go
	deleted:    orm/internal/testpb/test_schema.pb.go
	deleted:    orm/internal/testpb/test_schema.proto
	deleted:    orm/internal/testpb/test_schema_query.pb.go
	deleted:    orm/internal/testpb/test_schema_query.proto
	deleted:    orm/internal/testpb/test_schema_query_grpc.pb.go
	deleted:    orm/internal/testutil/testutil.go
	deleted:    orm/model/doc.go
	deleted:    orm/model/ormdb/file.go
	deleted:    orm/model/ormdb/testdata/bank_scenario.golden
	deleted:    orm/model/ormdb/testdata/default_json.golden
	deleted:    orm/model/ormlist/options.go
	deleted:    orm/model/ormtable/auto_increment.go
	deleted:    orm/model/ormtable/build.go
	deleted:    orm/model/ormtable/doc.go
	deleted:    orm/model/ormtable/duration_test.go
	deleted:    orm/model/ormtable/filter.go
	deleted:    orm/model/ormtable/index.go
	deleted:    orm/model/ormtable/index_impl.go
	deleted:    orm/model/ormtable/paginate.go
	deleted:    orm/model/ormtable/primary_key.go
	deleted:    orm/model/ormtable/save_test.go
	deleted:    orm/model/ormtable/singleton.go
	deleted:    orm/model/ormtable/singleton_test.go
	deleted:    orm/model/ormtable/table.go
	deleted:    orm/model/ormtable/table_impl.go
	deleted:    orm/model/ormtable/testdata/bad_auto_inc.json
	deleted:    orm/model/ormtable/testdata/bad_auto_inc2.json
	deleted:    orm/model/ormtable/testdata/test_auto_inc.golden
	deleted:    orm/model/ormtable/testdata/test_scenario.golden
	deleted:    orm/model/ormtable/testdata/trivial_auto_inc_export.golden
	deleted:    orm/model/ormtable/timestamp_test.go
	deleted:    orm/model/ormtable/unique.go
	deleted:    orm/model/ormtable/util.go
	deleted:    orm/testing/ormmocks/docs.go
	deleted:    orm/testing/ormtest/membackend.go
	deleted:    orm/types/docs.go

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by them: orm/CHANGELOG.md
	deleted by them: orm/README.md
	deleted by them: orm/encoding/encodeutil/util.go
	deleted by them: orm/encoding/ormfield/bool.go
	deleted by them: orm/encoding/ormfield/codec_test.go
	deleted by them: orm/encoding/ormfield/duration.go
	deleted by them: orm/encoding/ormfield/duration_test.go
	deleted by them: orm/encoding/ormfield/enum.go
	deleted by them: orm/encoding/ormfield/int32.go
	deleted by them: orm/encoding/ormfield/int64.go
	deleted by them: orm/encoding/ormfield/string.go
	deleted by them: orm/encoding/ormfield/timestamp.go
	deleted by them: orm/encoding/ormfield/timestamp_test.go
	deleted by them: orm/encoding/ormfield/uint32.go
	deleted by them: orm/encoding/ormfield/uint64.go
	deleted by them: orm/encoding/ormkv/index_key.go
	deleted by them: orm/encoding/ormkv/key_codec.go
	deleted by them: orm/encoding/ormkv/primary_key.go
	deleted by them: orm/encoding/ormkv/unique_key.go
	deleted by them: orm/encoding/ormkv/unique_key_test.go
	deleted by them: orm/go.mod
	deleted by them: orm/go.sum
	deleted by them: orm/internal/codegen/file.go
	deleted by them: orm/internal/codegen/index.go
	deleted by them: orm/internal/codegen/query.go
	deleted by them: orm/internal/listinternal/options.go
	deleted by them: orm/internal/testkv/compare.go
	deleted by them: orm/internal/testkv/debug.go
	deleted by them: orm/internal/testkv/leveldb.go
	deleted by them: orm/internal/testkv/mem.go
	deleted by them: orm/model/ormdb/genesis.go
	deleted by them: orm/model/ormdb/module.go
	deleted by them: orm/model/ormdb/module_test.go
	deleted by them: orm/model/ormtable/auto_increment_test.go
	deleted by them: orm/model/ormtable/backend.go
	deleted by them: orm/model/ormtable/batch.go
	deleted by them: orm/model/ormtable/bench_test.go
	deleted by them: orm/model/ormtable/hooks.go
	deleted by them: orm/model/ormtable/iterator.go
	deleted by them: orm/model/ormtable/table_test.go
	deleted by them: orm/orm.go
	deleted by them: orm/sonar-project.properties
	deleted by them: orm/testing/ormmocks/hooks.go
	deleted by them: orm/testing/ormmocks/match.go
	deleted by them: orm/types/kv/store.go
	deleted by them: orm/types/ormerrors/errors.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot added the conflicts label Feb 7, 2025
@github-actions github-actions bot added the C:orm label Feb 7, 2025
@aljo242 aljo242 merged commit 158f146 into release/v0.50.x Feb 12, 2025
46 of 47 checks passed
@aljo242 aljo242 deleted the mergify/bp/release/v0.50.x/pr-23633 branch February 12, 2025 15:26
aljo242 pushed a commit that referenced this pull request Feb 12, 2025
@mergify @zrbecker @aljo242
chore: remove unused orm module (backport #23633) (#23637)
4cc5464 
Co-authored-by: Zachary Becker <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
C:orm conflicts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aljo242 @zrbecker