chore(baseapp): Use cosmossdk.io/core/codec instead of github.com/cosmos/cosmos-sdk/codec #23309
Conversation
📝 WalkthroughWalkthroughThis pull request involves updating the import path for the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
baseapp/abci_test.go (1)
41-41: Reorder imports according to project guidelinesThe imports should be ordered according to the project's guidelines using the following groups:
- Standard library
- External dependencies
- Internal dependencies (cosmossdk.io)
- Project dependencies (github.com/cosmos/cosmos-sdk)
- "cosmossdk.io/core/codec" + import ( + // Standard library + "bytes" + // ... + + // External dependencies + "github.com/cometbft/cometbft/crypto/secp256k1" + // ... + + // Internal dependencies + "cosmossdk.io/core/codec" + // ... + + // Project dependencies + "github.com/cosmos/cosmos-sdk/baseapp" + // ... + )🧰 Tools
🪛 golangci-lint (1.62.2)
41-41: File is not
gci-ed with --skip-generated -s standard -s default -s prefix(cosmossdk.io) -s prefix(github.com/cosmos/cosmos-sdk) --custom-order(gci)
📜 Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
baseapp/abci_test.go(1 hunks)baseapp/internal/protocompat/protocompat.go(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- baseapp/internal/protocompat/protocompat.go
🧰 Additional context used
📓 Path-based instructions (1)
baseapp/abci_test.go (2)
Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
Pattern **/*_test.go: "Assess the unit test code assessing sufficient code coverage for the changes associated in the pull request"
🪛 golangci-lint (1.62.2)
baseapp/abci_test.go
41-41: File is not gci-ed with --skip-generated -s standard -s default -s prefix(cosmossdk.io) -s prefix(github.com/cosmos/cosmos-sdk) --custom-order
(gci)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Summary
🔇 Additional comments (1)
baseapp/abci_test.go (1)
41-41: LGTM: Import path updated to use the core codec moduleThe change from
github.com/cosmos/cosmos-sdk/codectocosmossdk.io/core/codecaligns with the PR objective of migrating to the core codec module.🧰 Tools
🪛 golangci-lint (1.62.2)
41-41: File is not
gci-ed with --skip-generated -s standard -s default -s prefix(cosmossdk.io) -s prefix(github.com/cosmos/cosmos-sdk) --custom-order(gci)
Description
Partially addresses: #23253
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...
Summary by CodeRabbit
github.com/cosmos/cosmos-sdk/codectocosmossdk.io/core/codecin multiple filesThis change represents a technical update to the project's dependency management, ensuring compatibility with the latest Cosmos SDK core module.