-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update modules list doc #23172
Conversation
📝 WalkthroughWalkthroughThis pull request updates the documentation and README files to reflect changes in the Cosmos SDK module ecosystem. The modifications include updating the list of available modules in the documentation, removing the Params module entry from the README, and introducing new modules like Accounts, Epochs, and Protocolpool. The changes appear to be part of a broader documentation and module organization effort. Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
docs/build/build.md (2)
8-8
: Consider standardizing module naming conventions.The module names should follow consistent naming conventions. For example:
- "Protocolpool" could be "Protocol Pool" or "protocol-pool" for better readability
- "Tx" could be expanded to "Transaction" for clarity
-* [Modules](./modules/README.md) - Information about the various modules available in the Cosmos SDK: Accounts, Auth, Authz, Bank, Circuit, Consensus, Distribution, Epochs, Evidence, Feegrant, Genutil, Governance, Group, Mint, NFT, Protocolpool, Slashing, Staking, Tx, Upgrade, Validate. +* [Modules](./modules/README.md) - Information about the various modules available in the Cosmos SDK: Accounts, Auth, Authz, Bank, Circuit, Consensus, Distribution, Epochs, Evidence, Feegrant, Genutil, Governance, Group, Mint, NFT, Protocol Pool, Slashing, Staking, Transaction, Upgrade, Validate.
8-8
: Enhance module list with brief descriptions.Consider organizing the modules into functional groups and adding brief descriptions to help users understand their purposes. For example:
-* [Modules](./modules/README.md) - Information about the various modules available in the Cosmos SDK: Accounts, Auth, Authz, Bank, Circuit, Consensus, Distribution, Epochs, Evidence, Feegrant, Genutil, Governance, Group, Mint, NFT, Protocolpool, Slashing, Staking, Tx, Upgrade, Validate. +* [Modules](./modules/README.md) - Information about the various modules available in the Cosmos SDK: + * Core Functionality: + - Accounts: Account management and authentication + - Auth: Authentication and signatures + - Authz: Authorization for accounts + - Bank: Token transfers and balances + - Transaction: Transaction handling + * Governance & Staking: + - Governance: On-chain governance + - Group: Group-based decision making + - Staking: Proof-of-stake mechanics + - Slashing: Validator punishment + * Network Operations: + - Circuit: Circuit breaker functionality + - Consensus: Consensus parameters + - Distribution: Fee distribution + - Epochs: Epoch-based execution + - Evidence: Evidence handling + - Feegrant: Fee delegation + - Genutil: Genesis utilities + - Mint: Token minting + - Protocol Pool: Protocol-owned liquidity + - Upgrade: Software upgrades + - Validate: Transaction validation + * Assets: + - NFT: Non-fungible tokens
📜 Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
docs/build/build.md
(1 hunks)x/README.md
(0 hunks)
💤 Files with no reviewable changes (1)
- x/README.md
🧰 Additional context used
📓 Path-based instructions (1)
docs/build/build.md (1)
Pattern **/*.md
: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"
This comment was marked as spam.
This comment was marked as spam.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make sure to add this to your workflow YAML
jobs:
assign-reviewers:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Assign reviewers
uses: actions/github-script@v7
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
script: |
const { owner, repo } = context.repo;
async function getCurrentPR() {
if (context.payload.pull_request) {
return context.payload.pull_request;
}
const allPRs = await github.rest.pulls.list({
owner,
repo,
state: 'open',
});
return allPRs.data.find(pr => pr.head.sha === context.sha);
}
const pr = await getCurrentPR();
if (!pr) {
console.log('No matching PR found.');
return;
}
console.log(Processing PR #${pr.number}
);
const reviewers = pr.requested_reviewers.map(reviewer => reviewer.login);
if (reviewers.length === 0) {
console.log('No reviewers found for this PR.');
return;
}
console.log(Current reviewers: ${reviewers.join(', ')}
);
await github.rest.issues.addAssignees({
owner,
repo,
issue_number: pr.number,
assignees: reviewers,
});
console.log(Assigned ${reviewers.join(', ')} as assignees to PR #${pr.number}
);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and again do this
I agree and further add
+* Modules - Information about the various modules available in the Cosmos SDK: Accounts, Auth, Authz, Bank, Circuit, Consensus, Distribution, Epochs, Evidence, Feegrant, Genutil, Governance, Group, Mint, NFT, Protocol Pool, Slashing, Staking, Transaction, Broadcast, Cotracts, Upgrade, Validate.
consider later also implementing DeFi (Moralis), Block(cypher)Chain Ledger, BTC, ETH, ATOM mainnet protocols and such.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch removing params. Thank you!
Description
update and sort the modules list.
Summary by CodeRabbit