Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: collection filtered pagination (backport #23002) #23140

Closed
wants to merge 2 commits into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 31, 2024

Description

Fixes: https://github.com/cosmos/cosmos-sdk/actions/runs/12407898080/job/34638649373?pr=22981

  • Consider filtered results count when checking limit instead of iterated values count in CollectionFilteredPaginate. Assign key of next filtered result as next_key value in page response.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:

  • confirmed ! in the type prefix if API or client breaking change

  • targeted the correct branch (see PR Targeting)

  • provided a link to the relevant issue or specification

  • reviewed "Files changed" and left comments if necessary

  • included the necessary unit and integration tests

  • added a changelog entry to CHANGELOG.md

  • updated the relevant documentation or specification, including comments for documenting Go code

  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

  • New Features

    • Support for simulating nested messages.
    • Importing hex keys via standard input.
  • Improvements

    • Upgraded RocksDB libraries to support v9.
    • Simplified testing frameworks by removing unnecessary components.
  • Bug Fixes

    • Fixed issues with collection filtered pagination.
  • API Breaking Changes

    • Removed certain packages and methods, including testutil/network.

This is an automatic backport of pull request #23002 done by [Mergify](https://mergify.com).

(cherry picked from commit 697219c)

# Conflicts:
#	CHANGELOG.md
Copy link
Contributor Author

mergify bot commented Dec 31, 2024

Cherry-pick of 697219c has failed:

On branch mergify/bp/release/v0.50.x/pr-23002
Your branch is up to date with 'origin/release/v0.50.x'.

You are currently cherry-picking commit 697219c9c.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   types/query/collections_pagination.go
	modified:   types/query/collections_pagination_test.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   CHANGELOG.md

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot added the conflicts label Dec 31, 2024
@mergify mergify bot requested a review from a team as a code owner December 31, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants