Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: Refactor Validator Account Types/Bech32 Prefixing #2040

Merged
merged 41 commits into from
Aug 31, 2018
Merged

R4R: Refactor Validator Account Types/Bech32 Prefixing #2040

Changes from 1 commit
Commits
Show all changes
41 commits
Select commit Hold shift + click to select a range
9dc1c5e
Add new account bech32 prefixes with godocs
Aug 14, 2018
397a3ae
Restructure spacing of existing account code
Aug 14, 2018
1a06ce4
Update account godocs
Aug 14, 2018
fce04b5
More account godoc updates + new tm pub/addr helpers
Aug 14, 2018
d62938c
Update validator type to use new account types/bech32 prefixes
Aug 15, 2018
2c57829
Fix account documentation errors
Aug 15, 2018
fd4bb7f
Update Bech32 prefix for consensus nodes
Aug 15, 2018
a238db2
Update Bech32 spec doc
Aug 15, 2018
0a5fde8
Fix account type tests
Aug 15, 2018
6187395
Add missing account consensus functions, clear up godocs, and fix tests
Aug 15, 2018
8756a08
Add to TestRandBech32PubkeyConsistency check
Aug 15, 2018
0f63434
Update initialization of validator public keys
Aug 15, 2018
0cf73c1
Update query signing info command
Aug 15, 2018
d4eba75
Implement new ConsAddress type with associated unit tests
Aug 15, 2018
79aaaa4
[WIP] Update stake and slashing parameters
Aug 16, 2018
3bce888
Update all calls to MustBech32ifyValPub
Aug 16, 2018
9c67e9b
Merge branch 'develop' into bez/1910-refactor-bech32-stake-prefixing
Aug 20, 2018
2cf75c4
[WIP] Validator operator API updates
Aug 21, 2018
87d724f
[WIP] Fix and update unit tests
Aug 21, 2018
f51f272
Merge branch 'develop' into bez/1910-refactor-bech32-stake-prefixing
Aug 21, 2018
27f160e
Fix gov logs (helping to debug failing tests)
Aug 21, 2018
d547484
Fix gov tally
Aug 21, 2018
8ecc12e
Fix all broken x/ unit tests
Aug 21, 2018
38618a3
Update gaia app genesis address logic
Aug 21, 2018
3b435e5
Merge branch 'develop' into bez/1910-refactor-bech32-stake-prefixing
Aug 21, 2018
5a4d0b2
Fix linting errors
Aug 21, 2018
7382250
Fix broken LCD tests
Aug 21, 2018
8b164b4
Fix broken CLI tests
Aug 21, 2018
5a030d3
Implement command to get validator address and pubkey from key name
Aug 22, 2018
7e04609
Add support for getting validator key information via REST endpoint
Aug 22, 2018
394fdf8
Update PENDING log
Aug 22, 2018
ff92d76
Update docs
Aug 22, 2018
867321f
Revert GaiaGenTx.PubKey bech32 prefix
Aug 22, 2018
a1cef0d
Merge branch 'develop' into bez/1910-refactor-bech32-stake-prefixing
Aug 23, 2018
74cd3ec
Fix broken docs and cli tests
Aug 23, 2018
2808bb9
Merge branch 'develop' into bez/1910-refactor-bech32-stake-prefixing
Aug 23, 2018
ae612ee
Update genesis to use correct Bech32 (cons) prefix for pubkeys
Aug 23, 2018
280d895
Merge branch 'develop' into bez/1910-refactor-bech32-stake-prefixing
Aug 29, 2018
9c2370e
Update docs and unit tests to reflect new cosmos account bech32 prefix
Aug 29, 2018
3b1790d
Merge remote-tracking branch 'origin/develop' into bez/1910-refactor-…
rigelrozanski Aug 31, 2018
fea1392
minor formatting
rigelrozanski Aug 31, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix gov logs (helping to debug failing tests)
  • Loading branch information
Aleksandr Bezobchuk committed Aug 21, 2018
commit 27f160e6f3555fc79e1fdc966f8ed8c2f97aed1f
8 changes: 4 additions & 4 deletions x/gov/handler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,8 @@ func EndBlocker(ctx sdk.Context, keeper Keeper) (resTags sdk.Tags) {
resTags.AppendTag(tags.Action, tags.ActionProposalDropped)
resTags.AppendTag(tags.ProposalID, proposalIDBytes)

logger.Info("Proposal %d - \"%s\" - didn't mean minimum deposit (had only %s), deleted",
inactiveProposal.GetProposalID(), inactiveProposal.GetTitle(), inactiveProposal.GetTotalDeposit())
logger.Info(fmt.Sprintf("Proposal %d - \"%s\" - didn't mean minimum deposit (had only %s), deleted",
inactiveProposal.GetProposalID(), inactiveProposal.GetTitle(), inactiveProposal.GetTotalDeposit()))
}

// Check if earliest Active Proposal ended voting period yet
Expand Down Expand Up @@ -143,8 +143,8 @@ func EndBlocker(ctx sdk.Context, keeper Keeper) (resTags sdk.Tags) {
activeProposal.SetTallyResult(tallyResults)
keeper.SetProposal(ctx, activeProposal)

logger.Info("Proposal %d - \"%s\" - tallied, passed: %v",
activeProposal.GetProposalID(), activeProposal.GetTitle(), passes)
logger.Info(fmt.Sprintf("Proposal %d - \"%s\" - tallied, passed: %v",
activeProposal.GetProposalID(), activeProposal.GetTitle(), passes))

for _, valAddr := range nonVotingVals {
val := keeper.ds.GetValidatorSet().Validator(ctx, valAddr)
Expand Down