fix(hubl): malformed msgName and error handling #16601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-prbot
requested review from
a team,
aaronc and
samricotta
and removed request for
a team
julienrbrt
changed the title
julienrbrt
reviewed
Jun 19, 2023
tools/hubl/internal/compat.go
Outdated
| @@ -30,7 +30,7 @@ func loadFileDescriptorsGRPCReflection(ctx context.Context, client *grpc.ClientC | |||
| InterfaceName: iface, | |||
| }) | |||
| if err == nil { | |||
| interfaceImplNames = append(interfaceImplNames, implRes.ImplementationMessageNames...) | |||
| interfaceImplNames = append(interfaceImplNames, implRes.ImplementationMessageNames[1:]...) | |||
There was a problem hiding this comment.
can we get a length check just in case?
julienrbrt
requested changes
Jun 19, 2023
Co-authored-by: Julien Robert <[email protected]>
julienrbrt
approved these changes
Jun 20, 2023
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #16600
This PR corrects an unhandled error on hubl reflection over msgName types.
The error have been happening because the original messages started with a
/character, while the grpc server expects names without the/character.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change