R4R: Redelegation doesn't subtract from liquid #1660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1660 +/- ##
=========================================
Coverage ? 63.61%
=========================================
Files ? 122
Lines ? 6805
Branches ? 0
=========================================
Hits ? 4329
Misses ? 2230
Partials ? 246 |
cwgoes
force-pushed
the
rigel/redelegation-fix
branch
from
50e0fee to
b88fb7c
Compare
cwgoes
approved these changes
Jul 12, 2018
rigelrozanski
commented
Jul 13, 2018
| msgDelegate := newTestMsgDelegate(delegatorAddr, validatorAddr, initBond) | ||
| got = handleMsgDelegate(ctx, msgDelegate, keeper) | ||
| require.True(t, got.IsOK(), "expected delegation to be ok, got %v", got) | ||
|
|
||
| // balance should have been subtracted after delegation | ||
| amt2 := accMapper.GetAccount(ctx, delegatorAddr).GetCoins().AmountOf(denom) | ||
| require.Equal(t, amt1.Sub(sdk.NewInt(initBond)).Int64(), amt2.Int64(), "expected coins to be subtracted") |
There was a problem hiding this comment.
oh yeah, makes sense 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1630