refactor: Apply Yihuang's server blocking improvement #16252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-prbot
requested review from
a team,
alexanderbez and
likhita-809
and removed request for
a team
alexanderbez
approved these changes
May 22, 2023
yihuang
approved these changes
May 23, 2023
| func ListenForQuitSignals(cancelFn context.CancelFunc, logger log.Logger) { | ||
| // Note, the blocking behavior of this depends on the block argument. | ||
| // The caller must ensure the corresponding context derived from the cancelFn is used correctly. | ||
| func ListenForQuitSignals(g *errgroup.Group, block bool, cancelFn context.CancelFunc, logger log.Logger) { |
There was a problem hiding this comment.
Treat a nil g parameter as block=false, so we only need to add one extra parameter?
There was a problem hiding this comment.
Then we have to add another if statement in parent logic tho
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Applies Yi-huang's simplification from #16208 .
Makes ListenForQuitSignals optionally block, and thus removes the messy complications inside of startInProcess. I believe that this PR should have no changes over prior PR's.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change