changelog: Reorder items in the changelog #1611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additionally I've added the following entries:
* Added MinInt and MinUint functions
* The keys sub-module is now in the sdk
* [keys] New keys now have 24 word recovery keys, for heightened security
* \#872 - recovery phrases no longer all end in `abandon`
ValarDragon
requested review from
cwgoes,
ebuchman and
rigelrozanski
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #1611 +/- ##
==========================================
Coverage ? 64.12%
==========================================
Files ? 122
Lines ? 6754
Branches ? 0
==========================================
Hits ? 4331
Misses ? 2177
Partials ? 246 |
ebuchman
approved these changes
Jul 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've reordered the entries to have entries tagged under the same module put together. (I think it was kinda weird with them not together before)
Additionally I've added the following entries:
Added MinInt and MinUint functions
[keys] New keys now have 24 word recovery keys, for heightened security
Key Generation Errors #872 - recovery phrases no longer all end in
abandonUpdated all relevant documentation in docsUpdated all code comments where relevantUpdated CHANGELOG.mdUpdated Gaia/ExamplesFeel free to close this issue though, if there was some ordering, or we think that any sort of ordering doesn't matter. I don't feel strongly about it