Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: run orm tests #15885

Merged
merged 8 commits into from
Apr 20, 2023
Merged

ci: run orm tests #15885

merged 8 commits into from
Apr 20, 2023

Conversation

julienrbrt
Copy link
Member

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@github-actions github-actions bot added the C:orm label Apr 19, 2023
@julienrbrt
Copy link
Member Author

This is what I thought 🤯 orm tests are not running in CI at all.

@julienrbrt julienrbrt changed the title [do not merge] test: verify orm tests in CI ci: run orm tests Apr 19, 2023
@julienrbrt julienrbrt marked this pull request as ready for review April 19, 2023 14:47
@julienrbrt julienrbrt requested a review from a team as a code owner April 19, 2023 14:47
@github-prbot github-prbot requested review from a team, mark-rushakoff and atheeshp and removed request for a team April 19, 2023 14:49
@julienrbrt
Copy link
Member Author

julienrbrt commented Apr 19, 2023

ORM tests are indeed failing, this should be solved in another PR.
(https://github.com/cosmos/cosmos-sdk/actions/runs/4744721720/jobs/8426028685?pr=15885)

@julienrbrt julienrbrt enabled auto-merge April 19, 2023 14:52
@julienrbrt julienrbrt requested a review from aaronc April 19, 2023 14:56
@julienrbrt julienrbrt added this pull request to the merge queue Apr 20, 2023
Merged via the queue into main with commit b6812c1 Apr 20, 2023
@julienrbrt julienrbrt deleted the julien/orm branch April 20, 2023 15:05
@aaronc aaronc mentioned this pull request May 3, 2023
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants