Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add spec for circuit module #14481

Merged
merged 11 commits into from
Jan 6, 2023
Merged

feat: add spec for circuit module #14481

merged 11 commits into from
Jan 6, 2023

Conversation

tac0turtle
Copy link
Member

Description

Add preliminary spec for circuit breaker module.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@github-prbot github-prbot requested review from a team, kocubinski and atheeshp and removed request for a team January 4, 2023 14:57
@julienrbrt
Copy link
Member

julienrbrt commented Jan 4, 2023

Can you delete this folder in this PR too: https://github.com/cosmos/cosmos-sdk/tree/main/cosmos/
and update the proto (https://github.com/cosmos/cosmos-sdk/pull/14481/files#diff-a4786ace2dc62c7e7837801aabf6345c4856425341e150871cb689018cf10700R4) so make proto-gen generates it at the correct place (now x/circuit exists)

edit: done here

@julienrbrt julienrbrt changed the title feature: add spec for circuit module feat: add spec for circuit module Jan 4, 2023
@tac0turtle
Copy link
Member Author

opening this as r4r. Will pair with sam for onboarding and implement the spec

@tac0turtle tac0turtle marked this pull request as ready for review January 5, 2023 10:00
@tac0turtle tac0turtle requested a review from a team as a code owner January 5, 2023 10:00
tac0turtle and others added 2 commits January 5, 2023 19:38
Co-authored-by: Aleksandr Bezobchuk <[email protected]>
Co-authored-by: Aleksandr Bezobchuk <[email protected]>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 5, 2023

[Cosmos SDK] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! nit: spacing issues in some sentences.

@tac0turtle tac0turtle enabled auto-merge (squash) January 6, 2023 14:03
@tac0turtle tac0turtle merged commit 6f3380d into main Jan 6, 2023
@tac0turtle tac0turtle deleted the marko/circuit_spec branch January 6, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants