Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add missing field in denom metadata example #14461

Merged
merged 1 commit into from
Jan 2, 2023

Conversation

tbruyelle
Copy link
Contributor

@tbruyelle tbruyelle commented Jan 2, 2023

Description

name is a mandatory field and should be present in this example.

Origin: ignite/cli#3351
Related code: https://github.com/cosmos/cosmos-sdk/blob/main/x/bank/types/metadata.go#L20


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct docs: prefix in the PR title
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the documentation writing guidelines
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct docs: prefix in the PR title
  • confirmed all author checklist items have been addressed
  • confirmed that this PR only changes documentation
  • reviewed content for consistency
  • reviewed content for thoroughness
  • reviewed content for spelling and grammar
  • tested instructions (if applicable)

@tbruyelle tbruyelle requested a review from a team as a code owner January 2, 2023 09:56
@tbruyelle tbruyelle changed the title docs: add missing field in denom metadata docs: add missing field in denom metadata example Jan 2, 2023
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@tac0turtle tac0turtle enabled auto-merge (squash) January 2, 2023 10:04
@tac0turtle tac0turtle merged commit 572af96 into cosmos:main Jan 2, 2023
@tbruyelle tbruyelle deleted the patch-1 branch January 2, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants