-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Enforce order of store commits in root store #14385
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sort in loadVersion don't affect order in commit
But it don't mean the nodes in iavl tree are written in key's order though. |
@yihuang or @tac0turtle can I get another approval here? |
@catShaark could you rebase? It'll automerge. |
hi, @julienrbrt -- Sir, this is our best attempt at a rebase. The truth is, both Khanh and I are a little clueless when it comes to rebasing. I get that it is like "apply the differentialcommits to the branch I specify when I do"
|
It was :) rebase or merge does not really matter for PR anyway. I just meant syncing with main because the branch was out of date. If you still need some guidance, feel free to reach me on discord/slack. |
Description
From what I read, LSM backend used by the sdk prefer the keys to be commited in ascending order. Right now, there's no logic enforcing the order of
rootmulti.Store.stores
and so whenrootmulti.Store
commit, we can't be sure that we're commiting the module stores in ascending order.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change