refactor: Baseapp audit changes #14379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-prbot
requested review from
a team,
JeancarloBarrios and
atheeshp
and removed request for
a team
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
552
to
559
| } | ||
|
|
||
| // Returns the application's deliverState if app is in runTxModeDeliver, | ||
| // otherwise it returns the application's checkstate. | ||
| // prepareProposalState if app is in runTxPrepareProposal, processProposalState | ||
| // if app is in runTxProcessProposal, and checkState otherwise. | ||
| func (app *BaseApp) getState(mode runTxMode) *state { | ||
| switch mode { | ||
| case runTxModeDeliver: |
There was a problem hiding this comment.
Change potentially affects state.
Call sequence:
github.com/cosmos/cosmos-sdk/baseapp.validateBasicTxMsgs (baseapp/baseapp.go:539)
(*github.com/cosmos/cosmos-sdk/baseapp.BaseApp).runTx (baseapp/baseapp.go:618)
(*github.com/cosmos/cosmos-sdk/baseapp.BaseApp).DeliverTx (baseapp/baseapp.go:326)
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -162,7 +162,7 @@ | |||
| // already be initialized in InitChain. Otherwise app.deliverState will be | |||
| // nil, since it is reset on Commit. | |||
| if app.deliverState == nil { | |||
| app.setDeliverState(req.Header) | |||
| app.setState(runTxModeDeliver, req.Header) | |||
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods
facundomedica
changed the title
alexanderbez
approved these changes
Dec 21, 2022
|
LGTM! Thanks :) |
|
[Cosmos SDK] Kudos, SonarCloud Quality Gate passed!
|
alexanderbez
added
the
backport/v0.47.x
|
FYI @facundomedica -- audit PRs need to be backported to v0.47 :) |
mergify bot
pushed a commit
that referenced
this pull request
Dec 22, 2022
Co-authored-by: Aleksandr Bezobchuk <[email protected]> (cherry picked from commit 6d33fa8)
alexanderbez
pushed a commit
that referenced
this pull request
Dec 22, 2022
Co-authored-by: Facundo Medica <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some refactor from Amaury's and my notes.
Some other stuff is left, will do on a separate PR as those still need review
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change