-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(textual): Render long bytes hash #14275
Conversation
Another suggestion has come up that would apply to non-hashed binary data: break up the hex digits into groups of four, separated by spaces - for the same reason we break up numbers when we display them. Consider
versus
|
Other alternatives were considered but don't seem as good:
|
I'll update this PR to switch to add grouping by 4 characters as described in #14275 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…sdk into am/14206-bytes-hash
[Cosmos SDK] Kudos, SonarCloud Quality Gate passed! |
[Cosmos SDK - Tx] Kudos, SonarCloud Quality Gate passed! |
Description
Closes: #14206
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change