-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: misc fixes for cosmos-rosetta #13583
Changes from 11 commits
24f8cef
4eaa2bd
8ff651c
fc58c6d
be4facc
d6b9645
edf20cd
0c2779f
cee3d9f
47e0dab
8aa02d3
e07319d
83d60a4
56288da
9fd3d15
4d778ec
ab271ef
d59fc20
04dfe49
7f75a36
91882fb
0285cee
bdb125f
468b92c
17aecca
527a020
69f9558
ab148f2
fdb6613
66707bb
709662b
22fc835
d23da2f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,7 +7,7 @@ require ( | |
cosmossdk.io/depinject v1.0.0-alpha.2 | ||
cosmossdk.io/math v1.0.0-beta.3 | ||
cosmossdk.io/simapp v0.0.0-20220908203654-84d4bf5accad | ||
github.com/cosmos/cosmos-sdk v0.0.0-00010101000000-000000000000 | ||
github.com/cosmos/cosmos-sdk v0.46.1 | ||
github.com/cosmos/gogoproto v1.4.2 | ||
github.com/golang/mock v1.6.0 | ||
github.com/google/uuid v1.3.0 | ||
|
@@ -44,7 +44,8 @@ require ( | |
github.com/coinbase/rosetta-sdk-go v0.8.1 // indirect | ||
github.com/confio/ics23/go v0.7.0 // indirect | ||
github.com/cosmos/btcutil v1.0.4 // indirect | ||
github.com/cosmos/cosmos-proto v1.0.0-alpha8 // indirect | ||
github.com/cosmos/cosmos-proto v1.0.0-alpha7 // indirect | ||
cosmossdk.io/tools/rosetta v0.0.0-00010101000000-000000000000 // indirect | ||
github.com/cosmos/go-bip39 v1.0.0 // indirect | ||
github.com/cosmos/gorocksdb v1.2.0 // indirect | ||
github.com/cosmos/iavl v0.19.3 // indirect | ||
|
@@ -160,8 +161,10 @@ replace ( | |
// We always want to test against the latest version of the simapp. | ||
cosmossdk.io/simapp => ../simapp | ||
github.com/99designs/keyring => github.com/cosmos/keyring v1.2.0 | ||
github.com/coinbase/rosetta-sdk-go => github.com/coinbase/rosetta-sdk-go v0.8.2-0.20221007214527-e03849ba430a | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just curious why we need this import. Can we add a comment here. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It is linked to this issue : coinbase/mesh-sdk-go#449 It is so I can pass |
||
// We always want to test against the latest version of the SDK. | ||
github.com/cosmos/cosmos-sdk => ../. | ||
cosmossdk.io/tools/rosetta => ./../tools/rosetta | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This makes sense but can we add a comment above. |
||
// Fix upstream GHSA-h395-qcrw-5vmq vulnerability. | ||
// TODO Remove it: https://github.com/cosmos/cosmos-sdk/issues/10409 | ||
github.com/gin-gonic/gin => github.com/gin-gonic/gin v1.8.1 | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
#!/usr/bin/make -f | ||
|
||
all: build | ||
|
||
build: | ||
go build ./cmd/rosetta.go | ||
|
||
test: | ||
go test -mod=readonly -race ./... | ||
|
||
.PHONY: all build test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done!
done with the comments, taking a look to the tests now