refactor: move x/{moduleName}/test{ModuleName} to x/{moduleName}/testutil
#13427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienrbrt
commented
Sep 30, 2022
| @@ -138,9 +138,6 @@ func (suite *IntegrationTestSuite) SetupTest() { | |||
| suite.ctx = app.BaseApp.NewContext(false, tmproto.Header{Time: time.Now()}) | |||
| suite.fetchStoreKey = app.UnsafeFindStoreKey | |||
|
|
|||
| // suite.Require().NoError(suite.accountKeeper.SetParams(suite.ctx, authtypes.DefaultParams())) | |||
| suite.Require().NoError(suite.bankKeeper.SetParams(suite.ctx, types.DefaultParams())) | |||
There was a problem hiding this comment.
We don't need to set params here, given that we use an app.
aaronc
reviewed
Sep 30, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #13427 +/- ##
==========================================
- Coverage 54.12% 53.98% -0.14%
==========================================
Files 645 641 -4
Lines 55276 55017 -259
==========================================
- Hits 29917 29701 -216
+ Misses 22963 22931 -32
+ Partials 2396 2385 -11
|
julienrbrt
force-pushed
the
julien/tests
branch
from
0cdb88d to
37acc26
Compare
aaronc
approved these changes
Oct 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #XXXX
Noticed that while doing #13420. It makes no sense to have two testing packages.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change