Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate x/nft to use app wiring #12126

Merged
merged 6 commits into from
Jun 8, 2022

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Jun 2, 2022

Description

Implements part of: #12038


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt linked an issue Jun 2, 2022 that may be closed by this pull request
3 tasks
protoiface "google.golang.org/protobuf/runtime/protoiface"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
io "io"
reflect "reflect"

Check notice

Code scanning / CodeQL

Sensitive package import

Certain system packages contain functions which may be a possible source of non-determinism
@julienrbrt julienrbrt marked this pull request as ready for review June 7, 2022 20:34
@julienrbrt julienrbrt requested a review from a team as a code owner June 7, 2022 20:34
@codecov
Copy link

codecov bot commented Jun 7, 2022

Codecov Report

Merging #12126 (b4a5224) into main (7c4e4c1) will decrease coverage by 0.00%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #12126      +/-   ##
==========================================
- Coverage   65.99%   65.99%   -0.01%     
==========================================
  Files         672      672              
  Lines       71066    71060       -6     
==========================================
- Hits        46901    46894       -7     
- Misses      21502    21503       +1     
  Partials     2663     2663              
Impacted Files Coverage Δ
simapp/app.go 77.14% <57.14%> (-0.48%) ⬇️
crypto/keys/internal/ecdsa/privkey.go 81.13% <0.00%> (-1.89%) ⬇️

@tac0turtle tac0turtle merged commit 2094c13 into main Jun 8, 2022
@tac0turtle tac0turtle deleted the julien/12038-migrate-xnft-to-use-app-wiring branch June 8, 2022 10:38
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
* feat: migrate x/nft to use app wiring

* updates

* updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

migrate x/nft to use app wiring
3 participants