Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve gentx validation & error messages #11500

Merged
merged 14 commits into from
Mar 31, 2022
Merged

fix: Improve gentx validation & error messages #11500

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
0f7454f
Add validate gentx, debug error messages
anilcse Mar 30, 2022
569df40
Merge branch 'master' into anil/gentx_validation
anilcse Mar 30, 2022
bfa51af
Update x/genutil/gentx.go
anilcse Mar 30, 2022
14f9209
Update x/genutil/gentx.go
anilcse Mar 30, 2022
465b83b
Update x/genutil/gentx.go
anilcse Mar 30, 2022
fda9a47
Update x/genutil/types/genesis_state.go
anilcse Mar 30, 2022
9193d8e
Update x/genutil/types/genesis_state.go
anilcse Mar 30, 2022
7662bab
Update x/genutil/types/genesis_state.go
anilcse Mar 30, 2022
bbf1d24
Add godoc
anilcse Mar 30, 2022
ab48123
Merge branch 'master' into anil/gentx_validation
anilcse Mar 30, 2022
7287541
Merge branch 'master' into anil/gentx_validation
anilcse Mar 31, 2022
59cf1b5
replace panic with error
anilcse Mar 31, 2022
4b80396
Merge branch 'anil/gentx_validation' of github.com:cosmos/cosmos-sdk …
anilcse Mar 31, 2022
7e5c384
Fix test
anilcse Mar 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update x/genutil/types/genesis_state.go 
Co-authored-by: Aleksandr Bezobchuk <[email protected]>
  • Loading branch information
@anilcse @alexanderbez
anilcse and alexanderbez authored Mar 30, 2022
commit 7662bab0b7c42761a9b2aec468a8b731e20efe8c
3 changes: 1 addition & 2 deletions x/genutil/types/genesis_state.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,8 +117,7 @@ func ValidateAndGetGenTx(genTx json.RawMessage, txJSONDecoder sdk.TxDecoder) (sd

// TODO: abstract back to staking
if _, ok := msgs[0].(*stakingtypes.MsgCreateValidator); !ok {
return tx, fmt.Errorf(
"genesis transaction %v does not contain a MsgCreateValidator", tx)
return tx, fmt.Errorf("unexpected GenTx message type; expected: MsgCreateValidator, got: %T", msgs[0])
}

if err := msgs[0].ValidateBasic(); err != nil {
Expand Down