Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configurable Bech32 prefix for SDK users #4144

Closed
4 tasks
yangyanqing opened this issue Apr 17, 2019 · 1 comment · Fixed by #4300
Closed
4 tasks

Configurable Bech32 prefix for SDK users #4144

yangyanqing opened this issue Apr 17, 2019 · 1 comment · Fixed by #4300
Labels
C:Crypto S:proposed

Comments

@yangyanqing
Copy link
Contributor

Summary

Make BIP44Prefix configurable

Problem Definition

cosmos-sdk is SDK, should be able to adapt to more uses. But BIP44Prefix was defined as const, Coin type was fixed to 118.

Proposal

Developer can assign coin type through config file or function SetCoinType().

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@alexanderbez
Copy link
Contributor

/cc @jleni @cwgoes

@yangyanqing yangyanqing changed the title Make BIP44Prefix configurable Configurable Bech32 prefix for SDK users May 8, 2019
@yangyanqing yangyanqing mentioned this issue May 8, 2019
Merged
5 tasks
alessio pushed a commit that referenced this issue May 30, 2019
Configurable Bip44 CoinType & HdPath for SDK users (#4300)
1db10b0 
Closes: #4144
@yangyanqing yangyanqing mentioned this issue Jun 3, 2019
Merged
5 tasks
yun-yeo pushed a commit to yun-yeo/cosmos-sdk that referenced this issue Jun 17, 2019
Configurable Bip44 CoinType & HdPath for SDK users (cosmos#4300)
97338f9 
Closes: cosmos#4144
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C:Crypto S:proposed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Configurable Bip44 CoinType & HdPath for SDK users
2 participants
@alexanderbez @yangyanqing