Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document the ENV that can change both gaiad and gaiacli configuration settings #1973

Closed
jackzampolin opened this issue Aug 10, 2018 · 2 comments
Closed

Document the ENV that can change both gaiad and gaiacli configuration settings #1973

jackzampolin opened this issue Aug 10, 2018 · 2 comments
Labels
C:CLI

Comments

@jackzampolin
Copy link
Member

By default cobra allows you to set command line flags and configuration via ENV. These ENV need to be documented and noted.
mslipper added a commit to mslipper/cosmos-sdk that referenced this issue Aug 28, 2018
@mslipper
Add documentation regarding environment variables
4ddfef6 
Closes cosmos#1973.
@mslipper mslipper mentioned this issue Aug 28, 2018
Merged
5 tasks
@mslipper
Copy link
Contributor

Gaia uses Tendermint's command line setup methods, and those use Viper's AutomaticEnv method to allow pretty much every flag to be defined via an env var. Rather than list out each one individually I listed a warning in the security.md doc describing which prefixes to avoid in order to prevent accidentally setting any flags you don't mean to.

@alexanderbez alexanderbez mentioned this issue Aug 28, 2018
Merged
5 tasks
@jackzampolin
Copy link
Member Author

Thats a great call @mslipper. We can close this when #2171 and #2170 are merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C:CLI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mslipper @jackzampolin