Add cl

cosmos · Dec 1, 2021 · 66085ab · 66085ab
1 parent 77ca28a
commit 66085ab
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -112,6 +112,7 @@ Ref: https://keepachangelog.com/en/1.0.0/
 * (x/gov) [\#10373](https://github.com/cosmos/cosmos-sdk/pull/10373) Removed gov `keeper.{MustMarshal, MustUnmarshal}`.
 * [\#10348](https://github.com/cosmos/cosmos-sdk/pull/10348) StdSignBytes takes a new argument of type `*tx.Tip` for signing over tips using LEGACY_AMINO_JSON.
 * [\#10208](https://github.com/cosmos/cosmos-sdk/pull/10208) The `x/auth/signing.Tx` interface now also includes a new `GetTip() *tx.Tip` method for verifying tipped transactions. The `x/auth/types` expected BankKeeper interface now expects the `SendCoins` method too.
+* [\#10612](https://github.com/cosmos/cosmos-sdk/pull/10612) `baseapp.NewBaseApp` constructor function doesn't take the `sdk.TxDecoder` anymore. This logic has been moved into the TxDecoderMiddleware.
 
 ### Client Breaking Changes
 

diff --git a/types/tx/middleware.go b/types/tx/middleware.go
@@ -25,11 +25,11 @@ type ResponseSimulateTx struct {
 // Request is the tx request type used in middlewares.
 // At least one of Tx or TxBytes must be set. If only TxBytes is set, then
 // Tx will be populated by the TxDecoderMiddleware. If only Tx is set, then
-// some middleware (such as signature verification) will not work.
+// some middlewares (such as signature verification) will fail.
 //
 // In practice, the middleware stack is called from {Check,Deliver}Tx, which
-// on passes the TxBytes. Then, the TxDecoderMiddleware decodes the bytes into
-// the Tx field.
+// only passes the TxBytes. Then, the TxDecoderMiddleware decodes the bytes
+// intothe Tx field.
 type Request struct {
 	Tx      sdk.Tx
 	TxBytes []byte