Add mincommision param tests

x/staking/migrations/v045/store_test.go

@@ -0,0 +1,32 @@
+package v045_test
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/require"
+
+	"github.com/cosmos/cosmos-sdk/simapp"
+	"github.com/cosmos/cosmos-sdk/testutil"
+	sdk "github.com/cosmos/cosmos-sdk/types"
+	paramtypes "github.com/cosmos/cosmos-sdk/x/params/types"
+	v045staking "github.com/cosmos/cosmos-sdk/x/staking/migrations/v045"
+	"github.com/cosmos/cosmos-sdk/x/staking/types"
+)
+
+func TestStoreMigration(t *testing.T) {
+	encCfg := simapp.MakeTestEncodingConfig()
+	stakingKey := sdk.NewKVStoreKey("staking")
+	tStakingKey := sdk.NewTransientStoreKey("transient_test")
+	ctx := testutil.DefaultContext(stakingKey, tStakingKey)
+	paramstore := paramtypes.NewSubspace(encCfg.Codec, encCfg.Amino, stakingKey, tStakingKey, "staking")
+
+	// Check no params
+	require.False(t, paramstore.Has(ctx, types.KeyMinCommissionRate))
+
+	// Run migrations.
+	err := v045staking.MigrateStore(ctx, stakingKey, encCfg.Codec, paramstore)
+	require.NoError(t, err)
+
+	// Make sure the new params are set.
+	require.True(t, paramstore.Has(ctx, types.KeyMinCommissionRate))
+}

x/staking/types/params_test.go

@@ -5,6 +5,7 @@ import (
 
 	"github.com/stretchr/testify/require"
 
+	sdk "github.com/cosmos/cosmos-sdk/types"
 	"github.com/cosmos/cosmos-sdk/x/staking/types"
 )
 
@@ -21,3 +22,17 @@ func TestParamsEqual(t *testing.T) {
 	ok = p1.Equal(p2)
 	require.False(t, ok)
 }
+
+func Test_validateParams(t *testing.T) {
+	params := types.DefaultParams()
+
+	// default params have no error
+	require.NoError(t, params.Validate())
+
+	// validate mincommision
+	params.MinCommissionRate = sdk.NewDec(-1)
+	require.Error(t, params.Validate())
+
+	params.MinCommissionRate = sdk.NewDec(2)
+	require.Error(t, params.Validate())
+}