Skip to content

Commit

Permalink
fix merge errors
Browse files Browse the repository at this point in the history
  • Loading branch information
Randy Grok committed Nov 26, 2024
1 parent f78dbe0 commit 5718170
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 5 deletions.
6 changes: 3 additions & 3 deletions server/v2/cometbft/abci_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ package cometbft

import (
"context"
"cosmossdk.io/server/v2/cometbft/oe"
"crypto/sha256"
"encoding/json"
"errors"
Expand All @@ -12,6 +11,7 @@ import (
"testing"
"time"

"cosmossdk.io/server/v2/cometbft/oe"
abciproto "github.com/cometbft/cometbft/api/cometbft/abci/v1"
v1 "github.com/cometbft/cometbft/api/cometbft/types/v1"
"github.com/cosmos/gogoproto/proto"
Expand Down Expand Up @@ -729,6 +729,7 @@ func assertStoreLatestVersion(t *testing.T, store types.Store, target uint64) {

func TestOptimisticExecution(t *testing.T) {
c := setUpConsensus(t, 100_000, mempool.NoOpMempool[mock.Tx]{})

// Set up handlers
c.processProposalHandler = DefaultServerOptions[mock.Tx]().ProcessProposalHandler

Expand All @@ -738,8 +739,7 @@ func TestOptimisticExecution(t *testing.T) {
calledTimes++
return nil, errors.New("test error")
}

c.SetOptimisticExecution(oe.NewOptimisticExecution(log.NewNopLogger(), optimisticMockFunc))
c.optimisticExec = oe.NewOptimisticExecution(log.NewNopLogger(), optimisticMockFunc)

_, err := c.InitChain(context.Background(), &abciproto.InitChainRequest{
Time: time.Now(),
Expand Down
10 changes: 8 additions & 2 deletions server/v2/cometbft/server.go
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ func New[T transaction.Tx](
}
}

srv.Consensus = &consensus[T]{
c := &consensus[T]{
appName: appName,
version: getCometBFTServerVersion(),
app: app,
Expand All @@ -191,9 +191,15 @@ func New[T transaction.Tx](
getProtoRegistry: sync.OnceValues(gogoproto.MergedRegistry),
addrPeerFilter: srv.serverOptions.AddrPeerFilter,
idPeerFilter: srv.serverOptions.IdPeerFilter,
optimisticExec: oe.NewOptimisticExecution(logger, consensus.internalFinalizeBlock),
}

c.optimisticExec = oe.NewOptimisticExecution(
logger,
c.internalFinalizeBlock,
)

srv.Consensus = c

return srv, nil
}

Expand Down

0 comments on commit 5718170

Please sign in to comment.