fix(x/accounts/lockup): prevent double withdraw

x/accounts/defaults/lockup/lockup.go

@@ -5,6 +5,7 @@ import (
 	"context"
 	"errors"
 	"fmt"
+	"maps"
 	"time"
 
 	"github.com/cosmos/gogoproto/proto"
@@ -302,7 +303,13 @@ func (bva *BaseLockup) WithdrawUnlockedCoins(
 
 	amount := sdk.Coins{}
 
+	// deduplicate the denoms
+	denoms := make(map[string]struct{})
 	for _, denom := range msg.Denoms {
+		denoms[denom] = struct{}{}
+	}
+
+	for denom := range maps.Keys(denoms) {
 		balance, err := bva.getBalance(ctx, fromAddress, denom)
 		if err != nil {
 			return nil, err

x/accounts/defaults/lockup/periodic_locking_account_test.go

@@ -231,12 +231,16 @@ func TestPeriodicAccountWithdrawUnlockedCoins(t *testing.T) {
 		Time: startTime.Add(time.Minute * 1),
 	})
 
-	_, err = acc.WithdrawUnlockedCoins(sdkCtx, &lockuptypes.MsgWithdraw{
+	// withdraw unlocked token
+	resp, err := acc.WithdrawUnlockedCoins(sdkCtx, &lockuptypes.MsgWithdraw{
 		Withdrawer: "owner",
 		ToAddress:  "receiver",
-		Denoms:     []string{"test"},
+		Denoms:     []string{"test", "test"}, // duplicate tokens should be ignored
 	})
 	require.NoError(t, err)
+	require.Equal(t, resp.AmountReceived.Len(), 1)
+	require.Equal(t, resp.AmountReceived, sdk.NewCoins(sdk.NewCoin("test", math.NewInt(5))))
+	require.Equal(t, resp.Receiver, "receiver")
 }
 
 func TestPeriodicAccountGetLockCoinInfo(t *testing.T) {