draft TestStartCmdwithEmptyandNonEmptyMinGasPrices

server/config/config.go

@@ -3,6 +3,7 @@ package config
 import (
 	"fmt"
 	"strings"
+	"errors"
 
 	"github.com/spf13/viper"
 
@@ -21,6 +22,8 @@ const (
 	DefaultGRPCWebAddress = "0.0.0.0:9091"
 )
 
+var ErrMinGasPrices = errors.New("please set min gas price in app.toml or flag or env var")
+
 // BaseConfig defines the server's basic configuration
 type BaseConfig struct {
 	// The minimum gas prices a validator is willing to accept for processing a
@@ -309,7 +312,7 @@ func GetConfig(v *viper.Viper) Config {
 
 func (c Config) ValidateBasic() error {
 	if c.BaseConfig.MinGasPrices == "" {
-		return fmt.Errorf("please set min gas price in app.toml or flag or env var")
+		return ErrMinGasPrices
 	}
 
 	return nil

server/util_test.go

@@ -13,6 +13,7 @@ import (
 	"github.com/spf13/cobra"
 
 	"github.com/cosmos/cosmos-sdk/client/flags"
+	"github.com/cosmos/cosmos-sdk/server/config"
 )
 
 var CancelledInPreRun = errors.New("Canelled in prerun")
@@ -399,3 +400,26 @@ func TestInterceptConfigsWithBadPermissions(t *testing.T) {
 		t.Fatalf("Failed to catch permissions error, got: [%T] %v", err, err)
 	}
 }
+
+func TestStartCmdwithEmptyandNonEmptyMinGasPrices(t *testing.T){
+
+	// first case - raise an error
+	tempDir := t.TempDir()
+	cmd := StartCmd(nil, tempDir)
+
+
+	// MinGasPrices ="0.22  -> no error raised
+	cfg := config.DefaultConfig()
+	cfg.BaseConfig.MinGasPrices ="0.22"
+
+	cmd.PreRunE = preRunETestImpl
+
+	serverCtx := &Context{}
+	ctx := context.WithValue(context.Background(), ServerContextKey, serverCtx)
+
+	if err := cmd.ExecuteContext(ctx); err != CancelledInPreRun {
+		t.Fatalf("function failed with [%T] %v", err, err)
+	}
+
+}
+