feat: Support for wasmd >=0.29 by generating files via buf #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@apollo-sturdy can you rebase? that should take care of the MSRV issues |
apollo-sturdy
force-pushed
the
dev/generate-via-buf
branch
from
38010da to
5115198
Compare
Done! |
|
Looks like @apollo-sturdy not sure if you want to take that on or not. If not, I can |
Would be great if you could do it. I'm not too familiar with it or the main Cosmos SDK types as I mostly work with CosmWasm. |
|
Merged in #358 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
wasmd>= 0.29 started using buf, it brokeproto-build. This PR fixes it by instead generating the files via buf. Needless to say this changes requires users to have buf installed. See here for more context: #318 (comment)