Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(timeout-height): allow define optional timeout height parameter #1489

Merged
merged 6 commits into from
Nov 7, 2023
Merged

feat(timeout-height): allow define optional timeout height parameter #1489

merged 6 commits into from
Nov 7, 2023

Conversation

janfabian
Copy link
Contributor

Introduce timeout height option for signing transactions (amino and direct) to support new POB/block-sdk modules.

Skip's documentation for details: https://docs.skip.money/searcher-docs

@janfabian janfabian force-pushed the feat/timeout-height branch from 0620ad8 to f3cd085 Compare October 17, 2023 07:53
@janfabian janfabian force-pushed the feat/timeout-height branch from f3cd085 to 2bf0e05 Compare October 17, 2023 09:11
webmaster128
webmaster128 reviewed Oct 24, 2023
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, love it. High quality contribution ❤️

Some smaller changes. Then this can go in 0.32.

packages/cosmwasm-stargate/src/signingcosmwasmclient.spec.ts Show resolved Hide resolved
packages/cosmwasm-stargate/src/signingcosmwasmclient.spec.ts Outdated Show resolved Hide resolved
packages/cosmwasm-stargate/src/signingcosmwasmclient.spec.ts Outdated Show resolved Hide resolved
packages/cosmwasm-stargate/src/signingcosmwasmclient.ts Outdated Show resolved Hide resolved
packages/amino/src/signdoc.ts Outdated Show resolved Hide resolved
@webmaster128 webmaster128 added this to the 0.32.0 milestone Oct 24, 2023
@webmaster128
Copy link
Member

I just merged #1484 which turns all Long into bigints. Could you rebase this work onto current main?

@janfabian janfabian force-pushed the feat/timeout-height branch from a2573f7 to 2bf0e05 Compare October 25, 2023 14:24
@janfabian janfabian force-pushed the feat/timeout-height branch from 3fb1ad7 to b3f4839 Compare October 25, 2023 14:52
@janfabian janfabian force-pushed the feat/timeout-height branch from b3f4839 to efeb501 Compare October 25, 2023 15:11
@janfabian janfabian force-pushed the feat/timeout-height branch from 9ba0d30 to 5bdd121 Compare October 25, 2023 16:20
webmaster128
webmaster128 reviewed Oct 26, 2023
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add the parameter to signAndBroadcastSync and signAndBroadcast? I think signAndBroadcast is the highest level where people might need this. No need to write extra tests for those but just propagate the parameter.

@janfabian
Copy link
Contributor Author

Sure, I'm gonna add that tomorrow morning

@janfabian janfabian force-pushed the feat/timeout-height branch from 95afa1d to 423b309 Compare October 27, 2023 07:47
webmaster128
webmaster128 approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful, thank you!

@webmaster128 webmaster128 merged commit 0a9ab03 into cosmos:main Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webmaster128 webmaster128 webmaster128 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.32.0
Development

Successfully merging this pull request may close these issues.
2 participants
@janfabian @webmaster128