-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
authz queries to meet the expanded types provided in the sdk #1308
Conversation
This PR is split from #1307 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Diff looks good to me, thank you!
Could you add tests for the new queries to packages/stargate/src/modules/authz/queries.spec.ts
? There you already see a test for the grants
query which I guess can easily be copied and adapted.
I re-opened to try to trigger a CI run. Not sure what kind of problem CircleCI has here. Maybe a few more commits are sufficient, let's see. |
@webmaster128 Took some tries to get the linter/tests to work, since I am in Intellij which isn't well supported in this setup, but I believe this is now ready! |
@webmaster128 Any more notes? |
Pinging this for an update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thank you.
Just one point: could you make one describe
block per method? I.e. add the tests on the same level as describe("grants", () => {
. This allows us to add multiple tests per method (not needed here).
}); | ||
|
||
it("works querying by granter", async () => { | ||
pendingWithoutSimapp46(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added in cosmos-sdk 0.45.2 👍
@webmaster128 done |
Nice, thank you! Could you enable modification for maintainers? I rebased this to latest main and added a CHANGELOG entry to get it merged. |
@webmaster128 That is odd... I already have it set to allow edits by maintainers |
Hmm, very strange. Don't know. In this case could you rebase to latest main (or merge main here) and add this CHANGELOG entry to the Unreleased secition?
|
Done, pulled main and added the log entry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
No description provided.