Update Symphony chain.json chain-id to testnet-4 #5692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankurdotb
suggested changes
Dec 12, 2024
There was a problem hiding this comment.
The edits as-is are fine but there can be some improvements:
- The chain.json file typically contains URLs to genesis file. I can see this in the Github repo, but the chain.json currently provides it as
https://rpc.testnet.symphonychain.org/genesis. This is not a static URL to the genesis file, and did in fact time our with an error. (Hence why the static URL to that that file is better, than a proxy endpoint like it currently has.) - Take a look at the associated version.json file as well and update accordingly.
|
Thank you for the review - all should be addressed now. |
ankurdotb
suggested changes
Dec 13, 2024
cmancrypto
commented
Dec 18, 2024
|
Sorry - I thought I'd made the changes requested already, my apologies. |
|
all changes as requested should be made - I appreciate your assistance and I apologize for the delays. |
fix: rename assetlist chain to testnet3 fix: remove IBC channel which doesnt exist on testnet
|
thank you for your patience - my apologies for the issues in merging this one! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.