Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/374 will setting a property to deprecated be shown in the generated model #375

Conversation

mwadams
Copy link
Contributor

@mwadams mwadams commented Jun 4, 2024

Added the Obsolete attribute to the property when the type is Deprecated.

mwadams added 2 commits June 4, 2024 09:17
Updated the warning settings to allow Draft2020-12 code generation to use the obsolete attribute.
Copy link

github-actions bot commented Jun 4, 2024

Code Coverage Summary Report - Linux (net8.0)

Code Coverage

Package Line Rate Branch Rate Complexity Health
Corvus.Json.Specs 98% 79% 5001
Corvus.Json.CodeGeneration.Abstractions 86% 74% 1347
Corvus.Json.ExtendedTypes 39% 33% 17107
Corvus.Json.CodeGeneration.202012 31% 18% 27668
Corvus.Json.CodeGeneration.201909 31% 18% 27361
Corvus.Json.CodeGeneration.7 31% 18% 23887
Corvus.Json.CodeGeneration.6 32% 18% 21661
Corvus.Json.CodeGeneration.4 32% 18% 19919
Corvus.Json.CodeGeneration.OpenApi30 37% 20% 14833
Corvus.Json.JsonSchema.Draft201909 14% 14% 12408
Corvus.Json.JsonSchema.Draft202012 15% 14% 11933
Corvus.Json.JsonSchema.Draft4 15% 15% 7130
Corvus.Json.JsonSchema.Draft6 13% 13% 7933
Corvus.Json.JsonSchema.Draft7 15% 14% 7781
Corvus.Json.JsonSchema.OpenApi30 1% 1% 54430
Corvus.Json.Patch 25% 21% 4237
Summary 28% (96733 / 346106) 15% (33438 / 216385) 264636

Copy link

github-actions bot commented Jun 4, 2024

Test Results

     1 files  ±0       1 suites  ±0   18m 43s ⏱️ +8s
12 608 tests ±0  12 608 ✅ ±0  0 💤 ±0  0 ❌ ±0 
13 656 runs  ±0  13 656 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit dbbddb5. ± Comparison against base commit 34dd3b3.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jun 4, 2024

Code Coverage Summary Report - Windows (net481)

Code Coverage

Package Line Rate Branch Rate Complexity Health
Corvus.Json.Specs 98% 81% 4727
Corvus.Json.CodeGeneration.Abstractions 86% 75% 1339
Corvus.Json.ExtendedTypes 39% 36% 11333
Corvus.Json.CodeGeneration.202012 31% 18% 27671
Corvus.Json.CodeGeneration.201909 30% 18% 27364
Corvus.Json.CodeGeneration.7 31% 18% 23889
Corvus.Json.CodeGeneration.6 32% 18% 21663
Corvus.Json.CodeGeneration.4 32% 18% 19921
Corvus.Json.CodeGeneration.OpenApi30 37% 20% 14835
Corvus.Json.JsonSchema.Draft201909 15% 15% 11715
Corvus.Json.JsonSchema.Draft202012 16% 16% 11277
Corvus.Json.JsonSchema.Draft4 16% 16% 6687
Corvus.Json.JsonSchema.Draft6 14% 14% 7400
Corvus.Json.JsonSchema.Draft7 16% 16% 7288
Corvus.Json.JsonSchema.OpenApi30 1% 1% 51100
Corvus.Json.Patch 27% 23% 3945
Summary 28% (93553 / 331153) 16% (31884 / 204631) 252154

Copy link

github-actions bot commented Jun 4, 2024

Code Coverage Summary Report - Windows (net8.0)

Code Coverage

Package Line Rate Branch Rate Complexity Health
Corvus.Json.Specs 98% 79% 5001
Corvus.Json.CodeGeneration.Abstractions 86% 74% 1347
Corvus.Json.ExtendedTypes 39% 33% 17107
Corvus.Json.CodeGeneration.202012 31% 18% 27668
Corvus.Json.CodeGeneration.201909 31% 18% 27361
Corvus.Json.CodeGeneration.7 31% 18% 23887
Corvus.Json.CodeGeneration.6 32% 18% 21661
Corvus.Json.CodeGeneration.4 32% 18% 19919
Corvus.Json.CodeGeneration.OpenApi30 37% 20% 14833
Corvus.Json.JsonSchema.Draft201909 14% 14% 12408
Corvus.Json.JsonSchema.Draft202012 15% 14% 11933
Corvus.Json.JsonSchema.Draft4 15% 15% 7130
Corvus.Json.JsonSchema.Draft6 13% 13% 7933
Corvus.Json.JsonSchema.Draft7 15% 14% 7781
Corvus.Json.JsonSchema.OpenApi30 1% 1% 54430
Corvus.Json.Patch 25% 21% 4237
Summary 28% (96764 / 346106) 15% (33465 / 216385) 264636

@mwadams mwadams merged commit 54d9c78 into main Jun 4, 2024
13 checks passed
@mwadams mwadams deleted the feature/374-will-setting-a-property-to-deprecated-be-shown-in-the-generated-model branch June 4, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Will setting a property to deprecated be shown in the generated model?
1 participant