Use custom http.Client for AWS #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 14, 2017
|
I suspect the underlying issue here was golang/go#22724, fixed in Go 1.10.1, but it was valid to make the problem go away by raising the number of open connections. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The retry maxRetries change 0502e44 alerted to us with a problem with RequestErrors when talking to DynamoDB. Some queries are now reaching the maxRetry limit of 20 and fail.
After investigation https://github.com/weaveworks/service-conf/issues/1066 we believe these are caused by the sheer number of requests we are making due to non-persistent connections.
There is a bug in golang where the maximum idle connections per a host does not work as expected and golang kills idle connections aggressively golang/go#13801
This PR sets
MaxIdleConnsPerHostexplicitly to 100.This change has been tested locally where we have seen Request Errors reduced from a constant stream to none.
Fixes https://github.com/weaveworks/service-conf/issues/1066