Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove flapping test in tracing sampling #5047

Merged
merged 1 commit into from
Dec 16, 2022
Merged

Remove flapping test in tracing sampling #5047

merged 1 commit into from
Dec 16, 2022

Conversation

friedrichg
Copy link
Member

Signed-off-by: Friedrich Gonzalez [email protected]

What this PR does: Remove flapping test in tracing sampling

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

This was flapping like this

--- FAIL: Test_ShouldSample (0.13s)
    --- FAIL: Test_ShouldSample/should_sample_1% (0.03s)
        sampling_test.go:70: 
            	Error Trace:	/__w/cortex/cortex/pkg/tracing/sampler/sampling_test.go:70
            	Error:      	Max difference between 100 and 127 allowed is 10, but difference was -27
            	Test:       	Test_ShouldSample/should_sample_1%

@friedrichg friedrichg requested a review from alanprot December 16, 2022 14:12
@alanprot alanprot merged commit e6a3da9 into master Dec 16, 2022
@friedrichg friedrichg deleted the remove-flappy-test branch December 29, 2022 13:10
alexqyle pushed a commit to alexqyle/cortex that referenced this pull request May 2, 2023
@friedrichg @alexqyle
Remove flapping test in tracing sampling (cortexproject#5047)
6cb8a34 
Signed-off-by: Friedrich Gonzalez <[email protected]>

Signed-off-by: Friedrich Gonzalez <[email protected]>
Signed-off-by: Alex Le <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanprot alanprot alanprot approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@friedrichg @alanprot