Ensure grpc keepalive on all clients #3431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Pracucci <[email protected]>
Signed-off-by: Marco Pracucci <[email protected]>
pstibrany
approved these changes
Nov 2, 2020
|
These settings are too low, and will cause early disconnect of clients on idle connections. Cortex gRPC server uses 5 minutes as minimum time between pings. If client sends pings more often, it gets "ping strike". When client is greater than 2 "ping strikes", it is disconnected. With 20s keepalive ping on idle connection, this happens after 1 minute. weaveworks/common#205 will allow to configure lower settings on the gRPC server. |
|
Ping strikes are implemented in , with hard-coded max value of 2. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
We're not enabling gRPC keepalive for inter-service gRPC connections 😱 I guess it's time to do it. A sane hardcoded default should be fine for all cases. The gRPC storage plugin also had a timeout of 10m which looks a mistake.
New gRPC clients introduced for the query-scheduler (#3374) will benefit this too.
Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]