Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Thanos version to master #2335

Merged
merged 12 commits into from
Mar 31, 2020
Merged

Update Thanos version to master #2335

merged 12 commits into from
Mar 31, 2020

Conversation

pstibrany
Copy link
Contributor

@pstibrany pstibrany commented Mar 26, 2020 •
edited
Loading

What this PR does: This PR updates Thanos dependency to (214ff4480e93).

Work in progress

  • integrate changes in compactor: delayed deletes, separate blocks cleanup
  • expose postings compression in the cache
  • update documentation with new flags
  • verify metric schanges
  • expose memcache client object size option

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

pracucci
pracucci reviewed Mar 30, 2020
View reviewed changes
pkg/storage/tsdb/config.go Outdated Show resolved Hide resolved
pkg/storage/tsdb/index_cache.go Outdated Show resolved Hide resolved
pracucci
pracucci approved these changes Mar 30, 2020
View reviewed changes
Copy link
Contributor

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good job @pstibrany!

I went through the whole diff in Thanos and the only thing I've noticed is that we should map the new metric thanos_memcached_operation_skipped_total too. A part from this, LGTM!

pkg/compactor/compactor.go Outdated Show resolved Hide resolved
@pstibrany pstibrany marked this pull request as ready for review March 30, 2020 20:17
pstibrany added 12 commits March 30, 2020 23:02
@pstibrany
Updated Thanos to master
3c98dca 
Signed-off-by: Peter Štibraný <[email protected]>
@pstibrany
Integrate Compactor and Store changes
a1cc47b 
- Deletion delay, blocks cleaner
- Postings compression

Signed-off-by: Peter Štibraný <[email protected]>
@pstibrany
Expose max item size for memcached client.
f5b3be1 
Signed-off-by: Peter Štibraný <[email protected]>
@pstibrany
Added new metrics related to postings compression to block_store_metrics
e1eebff 
Signed-off-by: Peter Štibraný <[email protected]>
@pstibrany
Lint
401a8a0 
Signed-off-by: Peter Štibraný <[email protected]>
@pstibrany
Lint
739ee7e 
Signed-off-by: Peter Štibraný <[email protected]>
@pstibrany
CHANGELOG.md, documentation
058249f 
Signed-off-by: Peter Štibraný <[email protected]>
@pstibrany
Added prefix.
5f53f24 
Signed-off-by: Peter Štibraný <[email protected]>
@pstibrany
Removed unused option.
f781eea 
Signed-off-by: Peter Štibraný <[email protected]>
@pstibrany
Remap thanos_memcached_operation_skipped_total metric.
a132935 
Signed-off-by: Peter Štibraný <[email protected]>
@pstibrany
Comment that blocks_meta_modified is ignored.
780195d 
Signed-off-by: Peter Štibraný <[email protected]>
@pstibrany
Use promauto.With(registerer) to create metrics.
7cd48dd 
Signed-off-by: Peter Štibraný <[email protected]>
@pstibrany pstibrany merged commit 91dd129 into cortexproject:master Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pracucci pracucci pracucci approved these changes

Assignees
No one assigned
Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pstibrany @pracucci